Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fire show event if show is prevented because other element is tran... #14845

Closed
wants to merge 2 commits into from
Closed

Don't fire show event if show is prevented because other element is tran... #14845

wants to merge 2 commits into from

Conversation

hnrch02
Copy link
Collaborator

@hnrch02 hnrch02 commented Oct 22, 2014

...sitioning

Fixes #14844.

@hnrch02 hnrch02 added the js label Oct 22, 2014
@hnrch02 hnrch02 added this to the v3.2.1 milestone Oct 22, 2014
@hnrch02 hnrch02 self-assigned this Oct 22, 2014
@cvrebert
Copy link
Collaborator

Unit test?

@hnrch02
Copy link
Collaborator Author

hnrch02 commented Oct 22, 2014

That's why I've assigned it to myself and haven't merged it yet. I'm working on one.

@hnrch02
Copy link
Collaborator Author

hnrch02 commented Oct 22, 2014

Here we go.

@hnrch02 hnrch02 force-pushed the dont-fire-show-if-other-element-is-transitioning branch from b22084c to 4fb36ba Compare October 22, 2014 02:17
@hnrch02
Copy link
Collaborator Author

hnrch02 commented Oct 22, 2014

@cvrebert LGTY?

@cvrebert
Copy link
Collaborator

Yeah.

@hnrch02 hnrch02 closed this in e811a24 Oct 22, 2014
@hnrch02 hnrch02 deleted the dont-fire-show-if-other-element-is-transitioning branch October 22, 2014 02:27
@cvrebert cvrebert mentioned this pull request Oct 22, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hnrch02 hnrch02

Labels
js
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

Collapse: show event fires even though show is prevented because other element is transitioning
2 participants
@hnrch02 @cvrebert