tooltip misplacement with top auto and bottom auto fixes #14763
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rebase this and force push it up again? If I check this PR out locally I don't see the changes you made to the unit test file. |
|
Also, the tests you added don't fail on current master. |
…psing class is removed)
- is(':visible') seems to be the only reliable check, without a refactoring of how hoverState is used
- tests need improvement
Also, link to the Mozilla bug in the relevant callout.
Added apostrophes to 3 words to indicate possession (i.e. ownership of something) instead of plurality (i.e. multiples of something).
* move unrelated .btn-primary example out of the pills subsection * remove excessive .nav-stacked example
If opening a modal when a scrollbar is present, closing it, then resizing the window so the scrollbar disappears, then opening the modal again, the content would shift. This fixes the problem by always calculating the scrollbar width every time a modal is opened. Closes twbs#14357.
`pointer-events: none;` for modern browsers (including IE11+), `clip: rect(1px, 1px, 1px, 1px);` for everything else. Fixes twbs#14137
…ntainer isn't interferred with by .jumbotron side padding
…n .navbar-form to prevent extra spacing
…ample in the docs
Also adds unit tests for keyboard events. Fixes twbs#14468.
…e so that Safari doesn't screw up overflow: hidden; content
[ci skip]
e68b7f0 to
7b2a332
Compare
Saranya-Raaj
pushed a commit
to Saranya-Raaj/bootstrap
that referenced
this pull request
Oct 10, 2014
Saranya-Raaj
pushed a commit
to Saranya-Raaj/bootstrap
that referenced
this pull request
Oct 10, 2014
Saranya-Raaj
pushed a commit
to Saranya-Raaj/bootstrap
that referenced
this pull request
Oct 10, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14756
Fixed jsbin