-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltip: Rely on getBoundingClientRect
for width
and height
#14599
Conversation
Well, I'm glad this lets us get rid of the weird SVG special-casing. Should we add a regression unit test for #14553, since none of the existing tests caught it? |
I was working on one, but I abandoned it because of IE8. I'll look into it more later. If you want to do it, please go ahead. |
nice work |
@cvrebert Any idea on how to do a cross-browser compatible unit test? rotate could work but would require a lot of CSS to work properly in all browsers. |
@hnrch02 My thought was that we should just disable the test in incompatible browsers (which would be only IE8?), like we already do in the SVG tooltip test. |
@cvrebert Think guarding it by var style = document.documentElement.style
if ('transform' in style || 'webkitTransform' in style || 'msTransform' in style) would suffice? |
Sounds good to me. |
Working on it. |
1508b11
to
5c3fdb8
Compare
Added a unit test. |
5c3fdb8
to
24ae068
Compare
@cvrebert LGTY? |
getBoundingClientRect
for width
and height
getBoundingClientRect
for width
and height
Yep. |
Tooltip: Rely on `getBoundingClientRect` for `width` and `height`
Fixes #14553.