Allow tabs to fade in if no initially active pane is present #13815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ref: #13814 |
|
I was just looking for this, so +1 from me! |
|
Rebased. |
| @@ -55,7 +55,7 @@ | |||
| var $active = container.find('> .active') | |||
| var transition = callback | |||
| && $.support.transition | |||
| && $active.hasClass('fade') | |||
| && (($active.length && $active.hasClass('fade')) || !!container.find('> .fade').length) | |||
There was a problem hiding this comment.
Does that first length check actually improve perf that much?
There was a problem hiding this comment.
It's not about perf, $active is empty when no tabs are shown, so the hasClass check would evaluate to false, preventing the feature this adds from working.
fat
added a commit
that referenced
this pull request
Jul 6, 2014
Allow tabs to fade in if no initially active pane is present
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can see the use case, do we want this?
Demonstration can be found here.
/cc @mdo @fat