Fixed useChryslerMapCorrection #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChryslerMapCorrection was broken when refactoring code in commit 419973f (Jun-6-2023). Code that used to be in functions.h got moved to trip_measurement.ino, and code that used to be in trip_measurement.ino got moved to trip_measurement.h. Moving them back allows useChryslerMapCorrection to compile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChryslerMapCorrection was broken when refactoring code in commit 419973f (Jun-6-2023). Code that used to be in functions.h got moved to trip_measurement.ino, and code that used to be in trip_measurement.ino got moved to trip_measurement.h. Moving them back allows useChryslerMapCorrection to compile.
I also changed EEPROM.h to eeprom.h to allow compiling on linux.
What caused useChryslerMapCorrection to break:
The code from functions.h was moved to trip_measurement.ino, which caused "error: 'prgmCalculateMAPpressure' was not declared in this scope" because the IDE couldn't access those function definitions ("#include functions.h" in mpguino_tav.ino).
The code from trip_measurement.ino was moved to trip_measurement.h, causing "Compilation error: 'tPressureChannel' was not declared in this scope".