Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update keytar to v7.7.0 #3467

Closed
ganthern opened this issue Sep 7, 2021 · 1 comment · Fixed by #3468
Closed

update keytar to v7.7.0 #3467

ganthern opened this issue Sep 7, 2021 · 1 comment · Fixed by #3468
Labels
bug broken functionality, usability problems, unexpected errors build issues that concern the build process (not only ci) state:done meets our definition of done state:tested We tested it and are about to release it
Milestone
3.88.0

Comments

@ganthern
Copy link
Contributor

ganthern commented Sep 7, 2021

keytar switched to N-API prebuilds (atom/node-keytar#331). this has a few consequences:

  • there are no dedicated binaries for electron 13, breaking the local desktop build which tries to fetch them
  • the local keytar build postinstall script needs changes
@ganthern ganthern added bug broken functionality, usability problems, unexpected errors build issues that concern the build process (not only ci) labels Sep 7, 2021
@ganthern ganthern added this to the Next release milestone Sep 7, 2021
@ganthern ganthern self-assigned this Sep 7, 2021
ganthern added a commit that referenced this issue Sep 7, 2021
@ganthern
update keytar to v7.7.0
8c438af 
the keytar build doesn't depend on runtime or
version anymore since it switched
from node headers to N-API.

close #3467
@ganthern ganthern mentioned this issue Sep 7, 2021
Merged
ganthern added a commit that referenced this issue Sep 7, 2021
@ganthern
update keytar to v7.7.0
6b1198d 
the keytar build doesn't depend on runtime or
version anymore since it switched
from node headers to N-API.

close #3467
@bedhub bedhub modified the milestones: Next release, 3.87.3 Sep 7, 2021
@bedhub bedhub added the state:done meets our definition of done label Sep 7, 2021
ganthern added a commit that referenced this issue Sep 9, 2021
@ganthern
update keytar to v7.7.0
9a2f403 
the keytar build doesn't depend on runtime or
version anymore since it switched
from node headers to N-API.

close #3467
ganthern added a commit that referenced this issue Sep 9, 2021
@ganthern
update keytar to v7.7.0
e6cb160 
the keytar build doesn't depend on runtime or
version anymore since it switched
from node headers to N-API.

close #3467
@bedhub
Copy link
Contributor

bedhub commented Sep 13, 2021 •
edited by charlag
Loading

Test notes
On all desktop client platforms (windows, linux, macos)

  • Check that after updating desktop client calendar event reminders are scheduled correctly.
  • Uninstall old client / install new one and receive new event reminders.

@bedhub bedhub added the state:tested We tested it and are about to release it label Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug broken functionality, usability problems, unexpected errors build issues that concern the build process (not only ci) state:done meets our definition of done state:tested We tested it and are about to release it
Projects
None yet
Milestone
3.88.0
Development

Successfully merging a pull request may close this issue.

update keytar to v7.7.0 tutao/tutanota
2 participants
@bedhub @ganthern