Remove Binary Dictionary Arithmetic Support (apache#4407)

* Remove Binary Dictionary Arithmetic Support * Clippy
tustvold · Jun 30, 2023 · a11b975 · a11b975
1 parent 0d4e6a7
commit a11b975
Show file tree

Hide file tree

Showing 5 changed files with 71 additions and 991 deletions.
diff --git a/.github/workflows/arrow.yml b/.github/workflows/arrow.yml
@@ -83,15 +83,15 @@ jobs:
       - name: Test arrow-ord with all features except SIMD
         run: cargo test -p arrow-ord --features dyn_cmp_dict
       - name: Test arrow-arith with all features except SIMD
-        run: cargo test -p arrow-arith --features dyn_arith_dict
+        run: cargo test -p arrow-arith
       - name: Test arrow-row with all features
         run: cargo test -p arrow-row --all-features
       - name: Test arrow-integration-test with all features
         run: cargo test -p arrow-integration-test --all-features
       - name: Test arrow with default features
         run: cargo test -p arrow
       - name: Test arrow with all features apart from simd
-        run: cargo test -p arrow --features=force_validate,prettyprint,ipc_compression,ffi,dyn_cmp_dict,dyn_arith_dict,chrono-tz
+        run: cargo test -p arrow --features=force_validate,prettyprint,ipc_compression,ffi,dyn_cmp_dict,chrono-tz
       - name: Run examples
         run: |
           # Test arrow examples
@@ -209,11 +209,11 @@ jobs:
       - name: Clippy arrow-ord with all features except SIMD
         run: cargo clippy -p arrow-ord --all-targets --features dyn_cmp_dict -- -D warnings
       - name: Clippy arrow-arith with all features except SIMD
-        run: cargo clippy -p arrow-arith --all-targets --features dyn_arith_dict -- -D warnings
+        run: cargo clippy -p arrow-arith --all-targets -- -D warnings
       - name: Clippy arrow-row with all features
         run: cargo clippy -p arrow-row --all-targets --all-features -- -D warnings
       - name: Clippy arrow with all features except SIMD
-        run: cargo clippy -p arrow --features=prettyprint,csv,ipc,test_utils,ffi,ipc_compression,dyn_cmp_dict,dyn_arith_dict,chrono-tz --all-targets -- -D warnings
+        run: cargo clippy -p arrow --features=prettyprint,csv,ipc,test_utils,ffi,ipc_compression,dyn_cmp_dict,chrono-tz --all-targets -- -D warnings
       - name: Clippy arrow-integration-test with all features
         run: cargo clippy -p arrow-integration-test --all-targets --all-features -- -D warnings
       - name: Clippy arrow-integration-testing with all features

diff --git a/arrow-arith/Cargo.toml b/arrow-arith/Cargo.toml
@@ -44,9 +44,5 @@ num = { version = "0.4", default-features = false, features = ["std"] }
 
 [dev-dependencies]
 
-[package.metadata.docs.rs]
-features = ["dyn_arith_dict"]
-
 [features]
-dyn_arith_dict = []
 simd = ["arrow-array/simd"]