Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon): uses n as CSS vars prefix #2004

Merged
merged 4 commits into from
Dec 24, 2021

Conversation

ahwgs
Copy link
Contributor

@ahwgs ahwgs commented Dec 23, 2021

ref #1842
close #1990

@vercel
Copy link

vercel bot commented Dec 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/BvZCnPBrpT8dWRCgUDdCQWEdW5pS
✅ Preview: https://naive-ui-git-fork-ahwgs-feat-icon-css-var-tusimple.vercel.app

@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #2004 (6853799) into main (3bb4fa0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2004   +/-   ##
=======================================
  Coverage   64.62%   64.62%           
=======================================
  Files         893      893           
  Lines       17472    17472           
  Branches     4143     4143           
=======================================
  Hits        11291    11291           
  Misses       5399     5399           
  Partials      782      782           
Impacted Files Coverage Δ
src/icon/src/Icon.ts 90.47% <ø> (ø)
src/icon/src/styles/index.cssr.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bb4fa0...6853799. Read the comment docs.

@XieZongChen XieZongChen merged commit c4fb48e into tusen-ai:main Dec 24, 2021
@ahwgs ahwgs deleted the feat-icon-css-var branch December 24, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

let CSS var prefixed with n for icon
2 participants