Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avatar tag dynamic-tags): use n as CSS vars prefix #1881

Merged
merged 6 commits into from
Dec 19, 2021

Conversation

Sepush
Copy link
Collaborator

@Sepush Sepush commented Dec 17, 2021

Signed-off-by: Sepush sepush@outlook.com

use n as CSS vars prefix for n-avatar n-tag n-dynamic-tags

ref #1842

Signed-off-by: Sepush <sepush@outlook.com>
@vercel
Copy link

vercel bot commented Dec 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/F7AoFdnocMXU3af38vsWryYrjUtZ
✅ Preview: Failed

[Deployment for 6ef886c failed]

Signed-off-by: Sepush <sepush@outlook.com>
Signed-off-by: Sepush <sepush@outlook.com>
@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #1881 (673ed91) into main (9d71ed4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 673ed91 differs from pull request most recent head 6ef886c. Consider uploading reports for the commit 6ef886c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1881      +/-   ##
==========================================
+ Coverage   64.61%   64.63%   +0.01%     
==========================================
  Files         890      890              
  Lines       17403    17403              
  Branches     4127     4126       -1     
==========================================
+ Hits        11245    11248       +3     
+ Misses       5379     5375       -4     
- Partials      779      780       +1     
Impacted Files Coverage Δ
src/avatar/src/styles/index.cssr.ts 100.00% <ø> (ø)
src/dynamic-tags/src/DynamicTags.tsx 75.00% <ø> (ø)
src/dynamic-tags/src/styles/index.cssr.ts 100.00% <ø> (ø)
src/tag/src/styles/index.cssr.ts 100.00% <ø> (ø)
src/tag/src/styles/rtl.cssr.ts 100.00% <ø> (ø)
src/avatar/src/Avatar.tsx 79.31% <100.00%> (ø)
src/tag/src/Tag.tsx 80.85% <100.00%> (ø)
src/form/styles/light.ts 100.00% <0.00%> (ø)
src/data-table/src/TableParts/Cell.tsx 100.00% <0.00%> (ø)
src/_utils/composable/use-houdini.ts 66.66% <0.00%> (+26.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d71ed4...6ef886c. Read the comment docs.

Signed-off-by: Sepush <sepush@outlook.com>
@Sepush Sepush changed the title feat(avatar): use n as CSS vars prefix feat(avatar tag dynamic-tags): use n as CSS vars prefix Dec 17, 2021
Copy link
Collaborator

@XieZongChen XieZongChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Signed-off-by: Sepush <sepush@outlook.com>
@Sepush
Copy link
Collaborator Author

Sepush commented Dec 18, 2021

image

thanks

@Sepush Sepush requested a review from XieZongChen December 18, 2021 04:53
@07akioni 07akioni merged commit 83df1c2 into tusen-ai:main Dec 19, 2021
@Sepush Sepush deleted the avatar branch December 19, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants