Permalinks should be able to decode and encode via servers. #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was skipping `&via` and just joining `via` when there were more servers. And it also just would not attempt to parse via servers when there was no event id to go with a room. turt2live#299 Signed-off-by: gnuxie <Gnuxie@protonmail.com>
Gnuxie
added a commit
to the-draupnir-project/Draupnir
that referenced
this pull request
Mar 9, 2023
turt2live/matrix-bot-sdk#300 Element takes forever reviewing anything so i suspect it'll be months before Travis even sniffs it.
Gnuxie
added a commit
to the-draupnir-project/Draupnir
that referenced
this pull request
Mar 9, 2023
turt2live/matrix-bot-sdk#300 Element takes forever reviewing anything so i suspect it'll be months before Travis even sniffs it.
turt2live
reviewed
Mar 9, 2023
test/helpers/PermalinksTest.ts
Outdated
| @@ -4,27 +4,27 @@ describe('Permalinks', () => { | |||
| describe('forRoom', () => { | |||
| it('should generate a URL for a room ID', () => { | |||
| const roomId = "!test:example.org"; | |||
| const expected = `https://matrix.to/#/${roomId}`; | |||
| const expected = `https://matrix.to/#/${encodeURIComponent(roomId)}`; | |||
There was a problem hiding this comment.
not encoding is deliberate for compatibility with some clients: the SDK should be able to parse encoded and unencoded URLs, but should not be producing encoded URLs.
There was a problem hiding this comment.
ok, that's no problem, I've changed it
Historically, clients have not produced URIs which are fully encoded. Clients should try to interpret these cases to the best of their ability. For example, an unencoded room alias should still work within the client if possible.
The components of the matrix.to URI ( and ) are to be percent-encoded as per RFC 3986
Though the spec does imply the bad links should no longer be generated when it probably should not.
turt2live
reviewed
Mar 19, 2023
turt2live
approved these changes
Mar 19, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was skipping
&viaand just joiningviawhen there were more servers. And it also just would not attempt to parse via servers when there was no event id to go with a room.Closes #299
Checklist