Remove slog-async dependency #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the slog-term docs:
> PlainSync Decorator implementation
>
> This implementation is exactly like PlainDecorator but it takes
> care of synchronizing writes to io.
Since we care about colouring, wrap a slog_term::TermDecorator in a
std::sync::Mutex so that coloured output is still maintained.
This ensures that log messages will not be dropped when the logging
rate exceeds the backend's ability to drain (as the previous
slog-async backend could do). Previously when this occurred, the log
output would show the following:
slog-async: logger dropped messages due to channel overflow
An alternative might be to keep the slog-async dependency but use
slog_async::OverflowStrategy::Block to ensure that overflowing writes
will block, rather than forcing each write through the mutex.
Fixes tummychow#131
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the slog-term docs:
Since we care about colouring, wrap a slog_term::TermDecorator in a std::sync::Mutex so that coloured output is still maintained.
This ensures that log messages will not be dropped when the logging rate exceeds the backend's ability to drain (as the previous slog-async backend could do). Previously when this occurred, the log output would show the following:
An alternative might be to keep the slog-async dependency but use slog_async::OverflowStrategy::Block to ensure that overflowing writes will block, rather than forcing each write through the mutex.
Fixes #131