Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Javascript to Karaf bundle #19

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

ChriFo
Copy link
Collaborator

@ChriFo ChriFo commented Dec 12, 2024

I have to apologize for not testing the last release on a clean setup.
Because of changing the location of the webpack config file the Javascript output was not covered by the Karaf bundling.

@ChriFo ChriFo requested a review from tumbl3w33d December 12, 2024 21:36
@ChriFo ChriFo force-pushed the add-missing-js branch 7 times, most recently from 723213a to 720cde0 Compare December 13, 2024 07:46
Copy link
Owner

@tumbl3w33d tumbl3w33d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, we separate the fix from the other changes and release a 3.1.1 and 3.2.0 separately.

- adjust output folder in webpack config
@tumbl3w33d tumbl3w33d merged commit 532d59b into tumbl3w33d:main Dec 15, 2024
2 checks passed
tumbl3w33d pushed a commit that referenced this pull request Dec 15, 2024
- adjust output folder in webpack config
@ChriFo ChriFo deleted the add-missing-js branch December 15, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants