Merge pull request agola-io#223 from sgotti/executor_fix_stopping_of_…

…not_running_task executor: fix stopping of not running tasks
tulliobotti64 · Mar 2, 2020 · 53bcbf0 · 53bcbf0
2 parents af7a6a4 + 4256f5e
commit 53bcbf0
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/internal/services/executor/executor.go b/internal/services/executor/executor.go
@@ -1168,7 +1168,7 @@ func (e *Executor) taskUpdater(ctx context.Context, et *types.ExecutorTask) {
 		}()
 	}
 
-	if !et.Spec.Stop && et.Status.Phase == types.ExecutorTaskPhaseRunning {
+	if et.Status.Phase == types.ExecutorTaskPhaseRunning {
 		log.Infof("marking executor task %s as failed since there's no running task", et.ID)
 		et.Status.Phase = types.ExecutorTaskPhaseFailed
 		et.Status.EndTime = util.TimeP(time.Now())