Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support #1247

Merged
merged 2 commits into from
Jan 15, 2023
Merged

add support #1247

merged 2 commits into from
Jan 15, 2023

Conversation

tubone24
Copy link
Owner

PR title

Status

READY/IN DEVELOPMENT/HOLD

Description

A few sentences describing the overall goals of the pull request's commits.

Related PRs

List related PRs against other branches:

branch PR
other_pr_master link
other_pr_develop link

Todos

  • Tests
  • e2e Tests
  • Storybook
  • Documentation

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

git pull --prune
git checkout <feature_branch>
yarn test

Preview Deploy

Describe the URL of the Preview Deploy.

link

Impacted Areas in Application

List general components of the application that this PR will affect:

  • aaa
  • bbb

Screenshot

Replace FIXME_BRANCH_NAME, FIXME_PR_NUMBER in the URL below with this branch name and PR number.

Desktop

Width 1200px

Desktop Home

Mobile

Width 400px

mobile home

@github-actions github-actions bot temporarily deployed to development-storybook January 15, 2023 04:15 Inactive
@github-actions github-actions bot temporarily deployed to development January 15, 2023 04:15 Inactive
@coveralls
Copy link
Collaborator

coveralls commented Jan 15, 2023

Pull Request Test Coverage Report for Build 3921847714

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.602%

Totals Coverage Status
Change from base Build 3921439949: 0.0%
Covered Lines: 250
Relevant Lines: 280

💛 - Coveralls

@github-actions
Copy link
Contributor

Deploy Preview

Deploy path: /home/runner/work/blog/blog/public
Functions path: /home/runner/work/blog/blog/functions/src
Configuration path: /home/runner/work/blog/blog/netlify.toml
Deploying to draft URL...

Logs: https://app.netlify.com/sites/pensive-lamport-5822d2/deploys/63c37e8e24cc8a07f3dff571
Website Draft URL: https://63c37e8e24cc8a07f3dff571--pensive-lamport-5822d2.netlify.app

If everything looks good on your draft URL, deploy it to your main site URL with the --prod flag.
netlify deploy --prod

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

Memlab leaks report

page-load [7.4MB] (baseline) [s1] > action-on-page [8.9MB] (target) [s2] > revert [9MB] (final) [s3]  
------3 clusters------

--Similar leaks in this run: 655--
--Retained size of leaked objects: 108.6KB--
[<synthetic>] (synthetic) @1 [9.5MB]
  --4 (shortcut)--->  [Window / https://blog.tubone-project24.xyz] (object) @9835 [74.5KB]
  --setInterval (property)--->  [<closure>] (closure) @56625 [264 bytes]
  --context (internal)--->  [<function scope>] (object) @222081 [20 bytes]
  --previous (internal)--->  [<function scope>] (object) @155021 [14KB]
  --n (variable)--->  [t] (closure) @151099 [1.2KB]
  --context (internal)--->  [<function scope>] (object) @298369 [41.7KB]
  --n (variable)--->  [Object] (object) @310039 [41.6KB]
  --449 (element)--->  [Object] (object) @151259 [24 bytes]
  --exports (property)--->  [r] (closure) @135995 [2.1KB]
  --hasData (property)--->  [<closure>] (closure) @136033 [68 bytes]
  --context (internal)--->  [<function scope>] (object) @136331 [1.3KB]
  --e (variable)--->  [Object] (object) @136305 [1KB]
  --1 (element)--->  [Object] (object) @136307 [76 bytes]
  --aaAutocomplete (property)--->  [f] (object) @187227 [348 bytes]
  --$node (property)--->  [F] (object) @186897 [188 bytes]
  --0 (element)--->  [Detached HTMLSpanElement] (native) @38845 [348 bytes]
  --5 (element)--->  [Detached HTMLDivElement] (native) @40013 [196 bytes]
  --5 (element)--->  [Detached HTMLDivElement] (native) @39989 [196 bytes]
  --5 (element)--->  [Detached HTMLElement] (native) @39983 [196 bytes]
  --6 (element)--->  [Detached HTMLElement] (native) @39985 [196 bytes]
  --4 (element)--->  [Detached HTMLDivElement] (native) @39783 [196 bytes]
  --6 (element)--->  [Detached HTMLDivElement] (native) @39781 [196 bytes]
  --6 (element)--->  [Detached HTMLDivElement] (native) @39779 [196 bytes]
  --6 (element)--->  [Detached HTMLDivElement] (native) @39777 [196 bytes]
  --6 (element)--->  [Detached HTMLDivElement] (native) @39775 [196 bytes]
  --3 (element)--->  [Detached HTMLDivElement] (native) @39009 [196 bytes]
  --4 (element)--->  [Detached HTMLDivElement] (native) @39013 [196 bytes]
  --3 (element)--->  [Detached HTMLDivElement] (native) @39027 [196 bytes]
  --3 (element)--->  [Detached HTMLDivElement] (native) @39029 [196 bytes]
  --4 (element)--->  [Detached HTMLAnchorElement] (native) @39045 [1.7KB]
  --11 (element)--->  [Detached InternalNode] (native) @356996512 [120 bytes]
  --1 (element)--->  [Detached ElementIntersectionObserverData] (native) @350909824 [64 bytes]

--Similar leaks in this run: 119--
--Retained size of leaked objects: 28.8KB--
[<synthetic>] (synthetic) @1 [9.5MB]
  --4 (shortcut)--->  [Window / https://blog.tubone-project24.xyz] (object) @9835 [74.5KB]
  --___push (property)--->  [<closure>] (closure) @56817 [68 bytes]
  --context (internal)--->  [<function scope>] (object) @94027 [496 bytes]
  --i (variable)--->  [Module] (object) @136163 [5.8KB]
  --get version (property)--->  [version] (closure) @233425 [68 bytes]
  --context (internal)--->  [<function scope>] (object) @178237 [16.4KB]
  --Qn (variable)--->  [y] (object) @442973 [368 bytes]
  --props (property)--->  [Object] (object) @472883 [28 bytes]
  --children (property)--->  [Object] (object) @471399 [296 bytes]
  --props (property)--->  [Object] (object) @472617 [56 bytes]
  --children (property)--->  [Object] (object) @449957 [1.2KB]
  --__ (property)--->  [Object] (object) @449977 [1.1KB]
  --__ (property)--->  [Object] (object) @449999 [940 bytes]
  --__ (property)--->  [Object] (object) @450015 [736 bytes]
  --__d (property)--->  [Detached HTMLDivElement] (native) @342131 [272 bytes]
  --3 (element)--->  [Detached HTMLDivElement] (native) @342129 [196 bytes]
  --3 (element)--->  [Detached HTMLDivElement] (native) @342127 [196 bytes]
  --4 (element)--->  [Detached HTMLDivElement] (native) @341619 [8.5KB]
  --6 (element)--->  [Detached HTMLElement] (native) @341659 [15KB]
  --3 (element)--->  [Detached HTMLDivElement] (native) @341655 [13.4KB]
  --3 (element)--->  [Detached Text] (native) @119599232 [96 bytes]
  --2 (element)--->  [Detached HTMLHeadingElement] (native) @49899936 [264 bytes]
  --6 (element)--->  [Detached InternalNode] (native) @49354848 [56 bytes]
  --1 (element)--->  [Detached InternalNode] (native) @350977120 [56 bytes]
  --1 (element)--->  [Detached NodeList] (native) @350900224 [56 bytes]

--Similar leaks in this run: 10--
--Retained size of leaked objects: 808 bytes--
[<synthetic>] (synthetic) @1 [9.5MB]
  --4 (shortcut)--->  [Window / https://blog.tubone-project24.xyz] (object) @9835 [74.5KB]
  --__twttrll (property)--->  [Array] (object) @56901 [184 bytes]
  --push (property)--->  [e] (closure) @283129 [68 bytes]
  --context (internal)--->  [<function scope>] (object) @123247 [248 bytes]
  --n (variable)--->  [Object] (object) @279685 [13KB]
  --101 (element)--->  [Object] (object) @279873 [24 bytes]
  --exports (property)--->  [o] (closure) @282271 [68 bytes]
  --context (internal)--->  [<function scope>] (object) @124215 [6.2KB]
  --g (variable)--->  [Detached Text] (native) @40733 [396 bytes]
  --3 (element)--->  [Detached InternalNode] (native) @351404672 [272 bytes]
  --1 (element)--->  [Detached InternalNode] (native) @351950400 [272 bytes]
  --1 (element)--->  [Detached InternalNode] (native) @351950240 [272 bytes]
  --1 (element)--->  [Detached MutationObserverRegistration] (native) @351979808 [272 bytes]
  --1 (element)--->  [Detached MutationObserver] (native) @351918432 [192 bytes]
  --1 (element)--->  [Detached MutationObserver::Delegate] (native) @351918272 [80 bytes]
  --1 (element)--->  [Detached V8MutationCallback] (native) @350991488 [40 bytes]

github-actions bot pushed a commit that referenced this pull request Jan 15, 2023
github-actions bot pushed a commit that referenced this pull request Jan 15, 2023
github-actions bot pushed a commit that referenced this pull request Jan 15, 2023
github-actions bot pushed a commit that referenced this pull request Jan 15, 2023
@github-actions
Copy link
Contributor

Storybook Preview

Deploy path: /home/runner/work/blog/blog/storybook-static
Functions path: /home/runner/work/blog/blog/functions/src
Configuration path: /home/runner/work/blog/blog/netlify.toml
Deploying to draft URL...

Logs: https://app.netlify.com/sites/blog-storybook/deploys/63c37f073a64450828e13ad2
Website Draft URL: https://63c37f073a64450828e13ad2--blog-storybook.netlify.app

If everything looks good on your draft URL, deploy it to your main site URL with the --prod flag.
netlify deploy --prod

github-actions bot pushed a commit that referenced this pull request Jan 15, 2023
@github-actions
Copy link
Contributor

Lighthouse Score

Desktop

performance: 90
accessibility: 100
best-practices: 92
seo: 92
pwa: 100

Mobile

performance: 69
accessibility: 100
best-practices: 83
seo: 93
pwa: 100

@github-actions github-actions bot temporarily deployed to development January 15, 2023 04:48 Inactive
@github-actions github-actions bot temporarily deployed to development-storybook January 15, 2023 04:48 Inactive
@tubone24 tubone24 marked this pull request as ready for review January 15, 2023 04:51
@github-actions
Copy link
Contributor

Deploy Preview

Deploy path: /home/runner/work/blog/blog/public
Functions path: /home/runner/work/blog/blog/functions/src
Configuration path: /home/runner/work/blog/blog/netlify.toml
Deploying to draft URL...

Logs: https://app.netlify.com/sites/pensive-lamport-5822d2/deploys/63c386604ce9230cfd9d1031
Website Draft URL: https://63c386604ce9230cfd9d1031--pensive-lamport-5822d2.netlify.app

If everything looks good on your draft URL, deploy it to your main site URL with the --prod flag.
netlify deploy --prod

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

Storybook Preview

Deploy path: /home/runner/work/blog/blog/storybook-static
Functions path: /home/runner/work/blog/blog/functions/src
Configuration path: /home/runner/work/blog/blog/netlify.toml
Deploying to draft URL...

Logs: https://app.netlify.com/sites/blog-storybook/deploys/63c386b1a96e930f8dfdfbd4
Website Draft URL: https://63c386b1a96e930f8dfdfbd4--blog-storybook.netlify.app

If everything looks good on your draft URL, deploy it to your main site URL with the --prod flag.
netlify deploy --prod

github-actions bot pushed a commit that referenced this pull request Jan 15, 2023
github-actions bot pushed a commit that referenced this pull request Jan 15, 2023
github-actions bot pushed a commit that referenced this pull request Jan 15, 2023
github-actions bot pushed a commit that referenced this pull request Jan 15, 2023
github-actions bot pushed a commit that referenced this pull request Jan 15, 2023
@github-actions
Copy link
Contributor

Memlab leaks report

page-load [7.1MB] (baseline) [s1] > action-on-page [8.5MB] (target) [s2] > revert [8.5MB] (final) [s3]  
------3 clusters------

--Similar leaks in this run: 555--
--Retained size of leaked objects: 97.2KB--
[<synthetic>] (synthetic) @1 [9.1MB]
  --4 (shortcut)--->  [Window / https://blog.tubone-project24.xyz] (object) @9835 [59.5KB]
  --setTimeout (property)--->  [<closure>] (closure) @56041 [264 bytes]
  --context (internal)--->  [<function scope>] (object) @283555 [20 bytes]
  --previous (internal)--->  [<function scope>] (object) @161873 [14KB]
  --n (variable)--->  [t] (closure) @236709 [1.2KB]
  --context (internal)--->  [<function scope>] (object) @91265 [41.7KB]
  --n (variable)--->  [Object] (object) @244235 [41.6KB]
  --449 (element)--->  [Object] (object) @242251 [24 bytes]
  --exports (property)--->  [r] (closure) @161523 [2.1KB]
  --hasData (property)--->  [<closure>] (closure) @121595 [68 bytes]
  --context (internal)--->  [<function scope>] (object) @121591 [1.3KB]
  --e (variable)--->  [Object] (object) @239991 [1KB]
  --1 (element)--->  [Object] (object) @218047 [76 bytes]
  --aaAutocomplete (property)--->  [f] (object) @221963 [348 bytes]
  --$node (property)--->  [F] (object) @221975 [188 bytes]
  --0 (element)--->  [Detached HTMLSpanElement] (native) @38313 [348 bytes]
  --5 (element)--->  [Detached HTMLDivElement] (native) @39369 [5.6KB]
  --5 (element)--->  [Detached HTMLDivElement] (native) @40067 [196 bytes]
  --4 (element)--->  [Detached HTMLDivElement] (native) @39381 [196 bytes]
  --4 (element)--->  [Detached HTMLAnchorElement] (native) @39027 [1.7KB]
  --11 (element)--->  [Detached InternalNode] (native) @346987392 [120 bytes]
  --1 (element)--->  [Detached ElementIntersectionObserverData] (native) @346992832 [64 bytes]

--Similar leaks in this run: 128--
--Retained size of leaked objects: 28.8KB--
[<synthetic>] (synthetic) @1 [9.1MB]
  --4 (shortcut)--->  [Window / https://blog.tubone-project24.xyz] (object) @9835 [59.5KB]
  --___navigate (property)--->  [<closure>] (closure) @56241 [68 bytes]
  --context (internal)--->  [<function scope>] (object) @142899 [496 bytes]
  --i (variable)--->  [Module] (object) @118365 [5.8KB]
  --get version (property)--->  [version] (closure) @93773 [68 bytes]
  --context (internal)--->  [<function scope>] (object) @93777 [16.4KB]
  --Qn (variable)--->  [y] (object) @424993 [368 bytes]
  --props (property)--->  [Object] (object) @424975 [28 bytes]
  --children (property)--->  [Object] (object) @423721 [296 bytes]
  --props (property)--->  [Object] (object) @425003 [56 bytes]
  --children (property)--->  [Object] (object) @425013 [198.3KB]
  --__ (property)--->  [Object] (object) @433321 [198.2KB]
  --__ (property)--->  [Object] (object) @433333 [198KB]
  --__ (property)--->  [Object] (object) @433347 [197.7KB]
  --__d (property)--->  [Detached HTMLDivElement] (native) @321955 [272 bytes]
  --3 (element)--->  [Detached HTMLDivElement] (native) @321917 [196 bytes]
  --3 (element)--->  [Detached HTMLDivElement] (native) @321915 [196 bytes]
  --4 (element)--->  [Detached HTMLDivElement] (native) @321369 [8.5KB]
  --4 (element)--->  [Detached HTMLAnchorElement] (native) @321337 [1.3KB]
  --10 (element)--->  [Detached HTMLAnchorElement] (native) @321343 [1.3KB]
  --10 (element)--->  [Detached HTMLAnchorElement] (native) @321349 [1.4KB]
  --12 (element)--->  [Detached InternalNode] (native) @347525120 [56 bytes]
  --1 (element)--->  [Detached InternalNode] (native) @347524960 [56 bytes]
  --1 (element)--->  [Detached NodeList] (native) @347035040 [56 bytes]

--Similar leaks in this run: 8--
--Retained size of leaked objects: 776 bytes--
[<synthetic>] (synthetic) @1 [9.1MB]
  --4 (shortcut)--->  [Window / https://blog.tubone-project24.xyz] (object) @9835 [59.5KB]
  --__twttrll (property)--->  [Array] (object) @55969 [184 bytes]
  --push (property)--->  [e] (closure) @283603 [68 bytes]
  --context (internal)--->  [<function scope>] (object) @75175 [248 bytes]
  --n (variable)--->  [Object] (object) @283595 [13KB]
  --162 (element)--->  [Object] (object) @288237 [1KB]
  --exports (property)--->  [<closure>] (closure) @288945 [984 bytes]
  --context (internal)--->  [<function scope>] (object) @282821 [916 bytes]
  --d (variable)--->  [Detached HTMLAnchorElement] (native) @40203 [228 bytes]
  --3 (element)--->  [Detached DOMTokenList] (native) @347105056 [56 bytes]

@github-actions
Copy link
Contributor

Lighthouse Score

Desktop

performance: 91
accessibility: 100
best-practices: 100
seo: 92
pwa: 100

Mobile

performance: 65
accessibility: 100
best-practices: 92
seo: 93
pwa: 100

github-actions bot pushed a commit that referenced this pull request Jan 15, 2023
github-actions bot pushed a commit that referenced this pull request Jan 15, 2023
github-actions bot pushed a commit that referenced this pull request Jan 15, 2023
github-actions bot pushed a commit that referenced this pull request Jan 15, 2023
github-actions bot pushed a commit that referenced this pull request Jan 15, 2023
@tubone24 tubone24 merged commit 5738eab into master Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants