only trigger deprecation warnings for non-empty attributes #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A deprecation that targeted the use of an attributte would always trigger, now we're only checking for deprecations on non-empty attributes.
|
I'm wondering if it might still be valuable for the caller to be aware of the deprecated attribute, even when it’s empty. Wouldn't it help guide users away from using deprecated fields altogether? |
|
Well, the problem is that there is no way to distinguish between an empty attribute and an unset attribute, so once you unconditionally deprecate an attribute the warning would always trigger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A deprecation that targeted the use of an attribute would always trigger, now we're only checking for deprecations on non-empty attributes.