Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option to specify stand-alone extensible enums:
It's possible to add, deprecate or forbid values:
This is used to make it possible to create a core/text block and then extend it with different roles:
A lot of the code changes are in service of making it possible for string constraints to return deprecation information.
As far as I could tell
DocumentConstraint.checkAttributes()
duplicatedvalidateDocumentAttributes()
so I removed that method and the call to it.checkDeprecation()
was extended to accept multiple deprecations.Document and block attributes, which always are "present" given that they map to struct fields and not map entries like data attributes, are not collected by revisor as values any more. Empty data attributes are still treated as signal.