Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nodejs] default to stable yarn 0.27.5 (--production flag works) #44

Closed

Conversation

lucasts
Copy link
Contributor

@lucasts lucasts commented Aug 2, 2017

  • update to latest yarn stable release
  • bring back --production flag

yarn>=0.20 fixed --production flag which would not install required packages.

yarn solution and explanation on what triggered the problem: yarnpkg/yarn#2537

@lucasts lucasts changed the title [nodejs] default to stable 0.27.5 where --prod flag works [nodejs] default to stable yarn 0.27.5 (--production flag works) Aug 2, 2017
@lucasts
Copy link
Contributor Author

lucasts commented Aug 2, 2017

@raphamorim @rwillrich what do you think?

@lucasts
Copy link
Contributor Author

lucasts commented Aug 2, 2017

closes #38 as well

@rwillrich
Copy link
Contributor

@lucasts we could use a SemVer compatible version range, like ^0.25.0, what do you think?

@raphamorim
Copy link
Contributor

Nice @lucasts

@rwillrich: This is a good suggest, but I like to recommend other version for SemVer approach: ^0.27.0

Because updates/fixes on issues about race condition and environment checker when script is running (more)

@lucasts
Copy link
Contributor Author

lucasts commented Aug 2, 2017

@raphamorim @rwillrich interesting But I personally do not trust yarn releases on that level.

From a tsuru standpoint I think it is better to have a fixed default version. users can specify a SemVer compatible string in their package.json if needed.

@raphamorim
Copy link
Contributor

raphamorim commented Aug 3, 2017

good point @lucasts,
make sense it to me 👍

If yarn breaks in any bad minor future version, we all break together 😆

@cezarsa
Copy link
Member

cezarsa commented Dec 11, 2017

Manually rebased/merged in 89314ac. I also bumped the default version to 1.3.2 as yarn should be stable now that we're past 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants