Skip to content
This repository has been archived by the owner on Apr 26, 2021. It is now read-only.

Commit

Permalink
gandalftest: implement grantAccess in testing server
Browse files Browse the repository at this point in the history
  • Loading branch information
Francisco Souza committed Feb 10, 2015
1 parent 252b68a commit 4bbc2c0
Show file tree
Hide file tree
Showing 2 changed files with 158 additions and 0 deletions.
64 changes: 64 additions & 0 deletions gandalftest/server.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ func (s *GandalfServer) buildMuxer() {
s.muxer.Get("/user/{name}/keys", http.HandlerFunc(s.listKeys))
s.muxer.Post("/user", http.HandlerFunc(s.createUser))
s.muxer.Delete("/user/{name}", http.HandlerFunc(s.removeUser))
s.muxer.Post("/repository/grant", http.HandlerFunc(s.grantAccess))
s.muxer.Post("/repository", http.HandlerFunc(s.createRepository))
s.muxer.Delete("/repository/{name}", http.HandlerFunc(s.removeRepository))
s.muxer.Get("/repository/{name}", http.HandlerFunc(s.getRepository))
Expand Down Expand Up @@ -201,6 +202,56 @@ func (s *GandalfServer) getRepository(w http.ResponseWriter, r *http.Request) {
}
}

func (s *GandalfServer) grantAccess(w http.ResponseWriter, r *http.Request) {
readOnly := r.URL.Query().Get("readonly") == "yes"
defer r.Body.Close()
var params map[string][]string
err := json.NewDecoder(r.Body).Decode(&params)
if err != nil {
http.Error(w, err.Error(), http.StatusBadRequest)
return
}
users := params["users"]
if len(users) < 1 {
http.Error(w, "missing users", http.StatusBadRequest)
return
}
repositories := params["repositories"]
if len(repositories) < 1 {
http.Error(w, "missing repositories", http.StatusBadRequest)
return
}
for _, user := range users {
_, index := s.findUser(user)
if index < 0 {
http.Error(w, fmt.Sprintf("user %q not found", user), http.StatusNotFound)
return
}
}
for _, repository := range repositories {
_, index := s.findRepository(repository)
if index < 0 {
http.Error(w, fmt.Sprintf("repository %q not found", repository), http.StatusNotFound)
return
}
}
for _, repository := range repositories {
repo, index := s.findRepository(repository)
for _, user := range users {
if !s.checkUserAccess(repo, user, readOnly) {
if readOnly {
repo.ReadOnlyUsers = append(repo.ReadOnlyUsers, user)
} else {
repo.Users = append(repo.Users, user)
}
}
}
s.repoLock.Lock()
s.repos[index] = repo
s.repoLock.Unlock()
}
}

func (s *GandalfServer) addKeys(w http.ResponseWriter, r *http.Request) {
userName := r.URL.Query().Get(":name")
var keys map[string]string
Expand Down Expand Up @@ -291,6 +342,19 @@ func (s *GandalfServer) findUser(name string) (userName string, index int) {
return "", -1
}

func (s *GandalfServer) checkUserAccess(repo repository.Repository, user string, readOnly bool) bool {
list := repo.Users
if readOnly {
list = repo.ReadOnlyUsers
}
for _, userName := range list {
if userName == user {
return true
}
}
return false
}

func (s *GandalfServer) findRepository(name string) (repository.Repository, int) {
s.repoLock.RLock()
defer s.repoLock.RUnlock()
Expand Down
94 changes: 94 additions & 0 deletions gandalftest/server_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,100 @@ func (s *S) TestListKeysUserNotFound(c *check.C) {
c.Assert(recorder.Body.String(), check.Equals, "user not found\n")
}

func (s *S) TestGrantAccess(c *check.C) {
server, err := NewServer("127.0.0.1:0")
c.Assert(err, check.IsNil)
defer server.Stop()
server.repos = []repository.Repository{{Name: "somerepo", Users: []string{"user1"}}, {Name: "otherrepo"}, {Name: "myrepo"}}
server.users = []string{"user1", "user2", "user3"}
recorder := httptest.NewRecorder()
body := strings.NewReader(`{"users":["user1","user2"],"repositories":["somerepo","myrepo"]}`)
request, _ := http.NewRequest("POST", "/repository/grant", body)
server.ServeHTTP(recorder, request)
c.Assert(recorder.Code, check.Equals, http.StatusOK)
c.Assert(server.repos[0].Users, check.DeepEquals, []string{"user1", "user2"})
c.Assert(server.repos[1].Users, check.HasLen, 0)
c.Assert(server.repos[2].Users, check.DeepEquals, []string{"user1", "user2"})
}

func (s *S) TestGrantAccessReadOnly(c *check.C) {
server, err := NewServer("127.0.0.1:0")
c.Assert(err, check.IsNil)
defer server.Stop()
server.repos = []repository.Repository{{Name: "somerepo", ReadOnlyUsers: []string{"user1"}}, {Name: "otherrepo"}, {Name: "myrepo"}}
server.users = []string{"user1", "user2", "user3"}
recorder := httptest.NewRecorder()
body := strings.NewReader(`{"users":["user1","user2"],"repositories":["somerepo","myrepo"]}`)
request, _ := http.NewRequest("POST", "/repository/grant?readonly=yes", body)
server.ServeHTTP(recorder, request)
c.Assert(recorder.Code, check.Equals, http.StatusOK)
c.Assert(server.repos[0].ReadOnlyUsers, check.DeepEquals, []string{"user1", "user2"})
c.Assert(server.repos[1].ReadOnlyUsers, check.HasLen, 0)
c.Assert(server.repos[2].ReadOnlyUsers, check.DeepEquals, []string{"user1", "user2"})
}

func (s *S) TestGrantAccessUserNotFound(c *check.C) {
server, err := NewServer("127.0.0.1:0")
c.Assert(err, check.IsNil)
defer server.Stop()
server.repos = []repository.Repository{{Name: "somerepo", Users: []string{"user1"}}, {Name: "otherrepo"}, {Name: "myrepo"}}
server.users = []string{"user1", "user2", "user3"}
recorder := httptest.NewRecorder()
body := strings.NewReader(`{"users":["user2","user4"],"repositories":["somerepo","myrepo"]}`)
request, _ := http.NewRequest("POST", "/repository/grant", body)
server.ServeHTTP(recorder, request)
c.Assert(recorder.Code, check.Equals, http.StatusNotFound)
c.Assert(recorder.Body.String(), check.Equals, `user "user4" not found`+"\n")
c.Assert(server.repos[0].Users, check.DeepEquals, []string{"user1"})
c.Assert(server.repos[1].Users, check.HasLen, 0)
c.Assert(server.repos[2].Users, check.HasLen, 0)
}

func (s *S) TestGrantAccessRepositoryNotFound(c *check.C) {
server, err := NewServer("127.0.0.1:0")
c.Assert(err, check.IsNil)
defer server.Stop()
server.repos = []repository.Repository{{Name: "somerepo", Users: []string{"user1"}}, {Name: "otherrepo"}, {Name: "myrepo"}}
server.users = []string{"user1", "user2", "user3"}
recorder := httptest.NewRecorder()
body := strings.NewReader(`{"users":["user2","user3"],"repositories":["somerepo","watrepo"]}`)
request, _ := http.NewRequest("POST", "/repository/grant", body)
server.ServeHTTP(recorder, request)
c.Assert(recorder.Code, check.Equals, http.StatusNotFound)
c.Assert(recorder.Body.String(), check.Equals, `repository "watrepo" not found`+"\n")
c.Assert(server.repos[0].Users, check.DeepEquals, []string{"user1"})
c.Assert(server.repos[1].Users, check.HasLen, 0)
c.Assert(server.repos[2].Users, check.HasLen, 0)
}

func (s *S) TestGrantAccessRepositoryMissingUsers(c *check.C) {
server, err := NewServer("127.0.0.1:0")
c.Assert(err, check.IsNil)
defer server.Stop()
server.repos = []repository.Repository{{Name: "somerepo", ReadOnlyUsers: []string{"user1"}}, {Name: "otherrepo"}, {Name: "myrepo"}}
server.users = []string{"user1", "user2", "user3"}
recorder := httptest.NewRecorder()
body := strings.NewReader(`{"repositories":["somerepo","watrepo"]}`)
request, _ := http.NewRequest("POST", "/repository/grant", body)
server.ServeHTTP(recorder, request)
c.Assert(recorder.Code, check.Equals, http.StatusBadRequest)
c.Assert(recorder.Body.String(), check.Equals, "missing users\n")
}

func (s *S) TestGrantAccessRepositoryMissingRepositories(c *check.C) {
server, err := NewServer("127.0.0.1:0")
c.Assert(err, check.IsNil)
defer server.Stop()
server.repos = []repository.Repository{{Name: "somerepo", ReadOnlyUsers: []string{"user1"}}, {Name: "otherrepo"}, {Name: "myrepo"}}
server.users = []string{"user1", "user2", "user3"}
recorder := httptest.NewRecorder()
body := strings.NewReader(`{"users":["user1","user2"]}`)
request, _ := http.NewRequest("POST", "/repository/grant", body)
server.ServeHTTP(recorder, request)
c.Assert(recorder.Code, check.Equals, http.StatusBadRequest)
c.Assert(recorder.Body.String(), check.Equals, "missing repositories\n")
}

func (s *S) TestPrepareFailure(c *check.C) {
server, err := NewServer("127.0.0.1:0")
c.Assert(err, check.IsNil)
Expand Down

0 comments on commit 4bbc2c0

Please sign in to comment.