assert unintialized and check for duplicates in registerTaskDefinitions

tsullivan · Oct 3, 2018 · ea8e5d3 · ea8e5d3
1 parent 33e18f0
commit ea8e5d3
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/x-pack/plugins/task_manager/task_manager.ts b/x-pack/plugins/task_manager/task_manager.ts
@@ -99,7 +99,17 @@ export class TaskManager {
     });
   }
 
+  /**
+   * Method for allowing consumers to register task definitions into the system.
+   * @param taskDefinitions - The Kibana task definitions dictionary
+   */
   public registerTaskDefinitions(taskDefinitions: TaskDictionary<TaskDefinition>) {
+    this.assertUninitialized('register task definitions');
+    const duplicate = Object.keys(taskDefinitions).find(k => !!this.definitions[k]);
+    if (duplicate) {
+      throw new Error(`Task ${duplicate} is already defined!`);
+    }
+
     const sanitized = sanitizeTaskDefinitions(
       taskDefinitions,
       this.maxWorkers,