Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spectre support #37

Merged
merged 11 commits into from
Nov 15, 2022
Merged

Spectre support #37

merged 11 commits into from
Nov 15, 2022

Conversation

tsmoreland
Copy link
Owner

Resolves #34

Changes

  • library output renamed to include _md or spectre_md for release builds or _mdd and spectre_mdd for debug builds
  • add target for spectre builds (debug/release builds using /QSpectre)
  • numerous command line updates for cl build arguments including changing to /MD instead of /MT)
  • expand _BITMAKS_OPS due to change in STL for preview release, what appears to be a breaking change with no condition to distinguish between new and old usage (the macro now takes 2 arguments, it used to take 1)

Tests

  • ✅ unit tests

@tsmoreland
tweaking cmake settings to produce a build using /QSpectre and vc143
b423bfd
@tsmoreland
update install path
874e559
@tsmoreland
update proecess_enums.h inlining the use of _BITMASK_OPS since the nu…
0156704 
…mber of arguments is changeing and I see no obvious way to control which version is used
@tsmoreland
- manually set cxx flags to avoid conflict between default /W3 and /M…
f30699c 
…T and what we're aiming for (/W4 and /MD)
@tsmoreland
- update triplet in base presets to x64-windows which seems to resolv…
6019e5a 
…e command line

generate problems for spectre build
- add debug spectre preset
@tsmoreland
adding build script, not yet working but shows the general concept of…
ee01409 
… what we will need to run (failures are due to path settings of cmake, need to use a developer powershell or command prompt for that to work then we get linking errors not seen when building in visual studio - likely due to the use of /MD)
@tsmoreland
- update library output to match configuration (including with or wit…
65f40f2 
…hout spectre)
@tsmoreland
rename nuspec and targets, will copy these (eventually) to support sp…
32cc25b 
…ectre package
@tsmoreland
correct spectre release build output name settings
b2019a0
@tsmoreland
add spectre environment to non-spectre builds set to false
d06025d 
updates the nuspec file to reference correct targets filename
@tsmoreland
corrections to nuspec/targets now able to build package(s)
2231a9c
@tsmoreland tsmoreland added bug Something isn't working enhancement New feature or request labels Nov 15, 2022
@tsmoreland tsmoreland self-assigned this Nov 15, 2022
@tsmoreland tsmoreland merged commit dccabac into main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tsmoreland tsmoreland

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Spectre build
1 participant
@tsmoreland