Allow multi-sample tips for Tree.draw_svg() #3010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this should allow us to e.g. collapse clades containing all non-tracked nodes. I will follow up with another PR to deal with large untracked polytomies. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3010 +/- ##
=======================================
Coverage 89.82% 89.82%
=======================================
Files 29 29
Lines 31986 32030 +44
Branches 6197 6207 +10
=======================================
+ Hits 28730 28772 +42
Misses 1859 1859
- Partials 1397 1399 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
4bb3779 to
b2f59f3
Compare
Closed
python/tskit/drawing.py
Outdated
| node_x_coord[c] for c in self.tree.children(u) if c in node_x_coord | ||
| ] | ||
| if len(child_coords) == 0: | ||
| raise ValueError( |
There was a problem hiding this comment.
Should try to cover this if possible
9d2965b to
0f4dc43
Compare
…ferent postorder This additional use of "order" is deliberately not documented.
0f4dc43 to
a54f16e
Compare
jeromekelleher
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @benjeffery, these are induced by passing a different (postorder) list as the
orderparameter. This additional use of "order" is deliberately not documented. Here's an example:The stored SVGs have changed because as part of the refactoring I properly rounded some floating point values, so now e.g. positions like
7.0are stored as simply7in the SVG, for clarity and efficiency.