Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

another try at #2915 #2927

Closed
wants to merge 2 commits into from

Conversation

petrelharp
Copy link
Contributor

No description provided.

…tion

Add test against worked example

Remove unused imports

More efficient windowing

Raise errors with invalid inputs

Misc. fixes and tests; add time discretisation argument

Test nonsuccinct case

Fix negative times for time windows

Delete accidental line copy

Remove unneeded if

Error message

Fix test for error message
Copy link
Contributor

mergify bot commented Apr 15, 2024

⚠️ The sha of the head commit of this PR conflicts with #2915. Mergify cannot evaluate rules on this PR. ⚠️

@petrelharp petrelharp mentioned this pull request Apr 15, 2024
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 0.72464% with 137 lines in your changes are missing coverage. Please review.

Project coverage is 81.60%. Comparing base (045b419) to head (5850551).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2927      +/-   ##
==========================================
+ Coverage   81.31%   81.60%   +0.29%     
==========================================
  Files          48       48              
  Lines       37856    37426     -430     
  Branches     7295     7232      -63     
==========================================
- Hits        30782    30542     -240     
+ Misses       5653     5466     -187     
+ Partials     1421     1418       -3     
Flag Coverage Δ
c-tests 86.21% <ø> (ø)
lwt-tests 80.78% <ø> (ø)
python-c-tests 68.45% <0.72%> (+0.74%) ⬆️
python-tests 98.97% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
python/tskit/stats.py 35.13% <ø> (+24.79%) ⬆️
python/tskit/trees.py 43.88% <0.72%> (-2.75%) ⬇️

... and 2 files with indirect coverage changes

@benjeffery
Copy link
Member

Closing in favour of #2915

@benjeffery benjeffery closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants