Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead tree apis #1936

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Conversation

jeromekelleher
Copy link
Member

🎉

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #1936 (1a4968c) into main (315e47a) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1936      +/-   ##
==========================================
+ Coverage   93.15%   93.25%   +0.09%     
==========================================
  Files          27       27              
  Lines       25085    25048      -37     
  Branches     1109     1109              
==========================================
- Hits        23369    23358      -11     
+ Misses       1682     1656      -26     
  Partials       34       34              
Flag Coverage Δ
c-tests 92.39% <100.00%> (+0.19%) ⬆️
lwt-tests 89.14% <ø> (ø)
python-c-tests 68.29% <ø> (ø)
python-tests 98.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
c/tskit/trees.c 94.97% <100.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 315e47a...1a4968c. Read the comment docs.

Copy link
Member

@benjeffery benjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good to get rid of the dead wood.

@benjeffery benjeffery added the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Nov 24, 2021
@mergify mergify bot merged commit a5b98f2 into tskit-dev:main Nov 24, 2021
@mergify mergify bot removed the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Nov 24, 2021
@jeromekelleher jeromekelleher deleted the remove-dead-tree-apis branch November 24, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants