Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JSON encoding error message #1827

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

benjeffery
Copy link
Member

Fixes #1505

@benjeffery benjeffery force-pushed the better-encoding-error branch from d3139a2 to c76fbd6 Compare October 20, 2021 13:36
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #1827 (c76fbd6) into main (5bd854d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c76fbd6 differs from pull request most recent head 647d36f. Consider uploading reports for the commit 647d36f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1827      +/-   ##
==========================================
- Coverage   93.39%   93.38%   -0.01%     
==========================================
  Files          27       27              
  Lines       24814    24787      -27     
  Branches     1094     1094              
==========================================
- Hits        23175    23148      -27     
  Misses       1604     1604              
  Partials       35       35              
Flag Coverage Δ
c-tests 92.11% <ø> (-0.02%) ⬇️
lwt-tests 89.14% <ø> (ø)
python-c-tests 94.53% <100.00%> (-0.01%) ⬇️
python-tests 98.75% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/tskit/exceptions.py 100.00% <100.00%> (ø)
python/tskit/metadata.py 98.85% <100.00%> (+<0.01%) ⬆️
c/tskit/trees.c 94.89% <0.00%> (-0.04%) ⬇️
python/_tskitmodule.c 91.67% <0.00%> (-0.01%) ⬇️
python/tskit/trees.py 97.83% <0.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bd854d...647d36f. Read the comment docs.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjeffery benjeffery added the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Oct 21, 2021
@benjeffery benjeffery force-pushed the better-encoding-error branch from c76fbd6 to 647d36f Compare October 21, 2021 10:53
@mergify mergify bot merged commit 039dca0 into tskit-dev:main Oct 21, 2021
@mergify mergify bot removed the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error message when metadata cannot be encoded
2 participants