Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs clarifications #1814

Merged
merged 1 commit into from
Oct 19, 2021
Merged

docs clarifications #1814

merged 1 commit into from
Oct 19, 2021

Conversation

petrelharp
Copy link
Contributor

Closes #1813 (I hope).

@petrelharp
Copy link
Contributor Author

Darn it, I need to figure out how to update all my pre-commit stuff...

@petrelharp
Copy link
Contributor Author

Ah, ok, that was painless actually. Let's see - here's my updated documentation:
Screenshot from 2021-10-18 10-22-57
and
Screenshot from 2021-10-18 10-23-16

@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #1814 (3a92cb3) into main (9f25482) will not change coverage.
The diff coverage is n/a.

❗ Current head 3a92cb3 differs from pull request most recent head c0c1da3. Consider uploading reports for the commit c0c1da3 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1814   +/-   ##
=======================================
  Coverage   93.41%   93.41%           
=======================================
  Files          27       27           
  Lines       24756    24756           
  Branches     1095     1095           
=======================================
  Hits        23127    23127           
  Misses       1594     1594           
  Partials       35       35           
Flag Coverage Δ
c-tests 92.16% <ø> (ø)
lwt-tests 89.14% <ø> (ø)
python-c-tests 94.55% <ø> (ø)
python-tests 98.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/tskit/trees.py 97.83% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f25482...c0c1da3. Read the comment docs.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some icing would be to put in doi http links for the papers, but I suspect a lot of them won't have dois.

@jeromekelleher jeromekelleher added the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Oct 19, 2021
@mergify mergify bot merged commit 6142f7f into tskit-dev:main Oct 19, 2021
@mergify mergify bot removed the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

some statistics clarifications
2 participants