Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change num_samples and num_tracked_samples to tsk_size_t #1727

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

benjeffery
Copy link
Member

Fixes #1723

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #1727 (0c275ca) into main (eac7482) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0c275ca differs from pull request most recent head 3c09b42. Consider uploading reports for the commit 3c09b42 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1727      +/-   ##
==========================================
- Coverage   93.36%   93.36%   -0.01%     
==========================================
  Files          27       27              
  Lines       24239    24236       -3     
  Branches     1093     1089       -4     
==========================================
- Hits        22631    22628       -3     
  Misses       1573     1573              
  Partials       35       35              
Flag Coverage Δ
c-tests 92.10% <100.00%> (+<0.01%) ⬆️
lwt-tests 89.25% <ø> (ø)
python-c-tests 94.51% <ø> (-0.01%) ⬇️
python-tests 98.75% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
c/tskit/stats.c 85.15% <ø> (ø)
c/tskit/haplotype_matching.c 95.05% <100.00%> (ø)
c/tskit/trees.c 94.87% <100.00%> (+<0.01%) ⬆️
python/tskit/trees.py 97.82% <0.00%> (-0.02%) ⬇️
c/tskit/tables.c 90.19% <0.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eac7482...3c09b42. Read the comment docs.

@jeromekelleher jeromekelleher added the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Sep 20, 2021
@benjeffery
Copy link
Member Author

@jeromekelleher Need a non-author approving review here.

@jeromekelleher
Copy link
Member

oops, thanks @benjeffery!

@mergify mergify bot merged commit 1a26153 into tskit-dev:main Sep 21, 2021
@mergify mergify bot removed the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change tsk_tree_t.num_samples to tsk_size_t
2 participants