-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor lwt and add force_64 option #1590
Conversation
c0f3916
to
5b3869d
Compare
Codecov Report
@@ Coverage Diff @@
## main #1590 +/- ##
==========================================
+ Coverage 93.60% 93.62% +0.01%
==========================================
Files 27 27
Lines 23036 23074 +38
Branches 1079 1079
==========================================
+ Hits 21562 21602 +40
+ Misses 1440 1438 -2
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, refactoring is an improvement! I assume we don't need an issue to track the logic flip as it is going to error out.
PyArrayObject *offset_array = NULL; | ||
bool offset_64 = force_offset_64; // || col->offset[col->num_rows] > UINT32_MAX | ||
int offset_type = offset_64 ? NPY_UINT64 : NPY_UINT32; | ||
/* TODO change this to 32 bit when we flip tsk_size_t over */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By this comment you mean the whole logic of this section will be flipped? I think I get it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, exactly.
df59a4f
to
0ef9b51
Compare
Closes #1589