Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C implementation of Colless index #2254

Closed
jeromekelleher opened this issue May 10, 2022 · 5 comments
Closed

C implementation of Colless index #2254

jeromekelleher opened this issue May 10, 2022 · 5 comments
Assignees
Labels
C API Issue is about the C API enhancement New feature or request
Milestone

Comments

@jeromekelleher
Copy link
Member

Requires #2250

Follow pattern established for #2253

@jeromekelleher jeromekelleher added C API Issue is about the C API enhancement New feature or request labels May 10, 2022
@jeromekelleher
Copy link
Member Author

Python version done in #2266

Would you like to do this one or will I pick it up @jeremyguez? It's slightly different to #2253 because we can use the built-in postorder rather than using a stack.

@jeremyguez
Copy link
Contributor

I can have a try at it, it would be a good experience. I'll look at #2253 and will tell you if I get stuck somewhere.

@jeromekelleher jeromekelleher added this to the Python 0.5.0 milestone May 20, 2022
@jeromekelleher
Copy link
Member Author

Any update here @jeremyguez? We're hoping to release Python 0.5.0 in the next few days, so if you're not going to get to it soon I can do the C updates.

@jeremyguez
Copy link
Contributor

Sorry @jeromekelleher, didn't know a release was coming soon.
I started to dive into the C code, but being at end of my PhD with the writing of the thesis/papers, I don't have much time at the moment. 😞
So yes, you can go ahead and do the C updates. I'll look at it when I have more time, to understand how you made it work. 😃

@jeromekelleher
Copy link
Member Author

No worries at all @jeremyguez, thanks for being so helpful with the rest of the implementation!

@jeromekelleher jeromekelleher self-assigned this Jun 15, 2022
jeromekelleher added a commit to jeromekelleher/tskit that referenced this issue Jun 16, 2022
jeromekelleher added a commit to jeromekelleher/tskit that referenced this issue Jun 16, 2022
jeromekelleher added a commit to jeromekelleher/tskit that referenced this issue Jun 16, 2022
jeromekelleher added a commit to jeromekelleher/tskit that referenced this issue Jun 16, 2022
jeromekelleher added a commit to jeromekelleher/tskit that referenced this issue Jun 16, 2022
jeromekelleher added a commit to jeromekelleher/tskit that referenced this issue Jun 16, 2022
@mergify mergify bot closed this as completed in a1b1e5d Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C API Issue is about the C API enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants