-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compile flag for supporting 64 bit IDs #1528
Milestone
Comments
jeromekelleher
added a commit
to jeromekelleher/tskit
that referenced
this issue
Jun 28, 2021
jeromekelleher
added a commit
to jeromekelleher/tskit
that referenced
this issue
Jun 28, 2021
Sounds good - I assume the define might have to disable some of the file format tests. |
jeromekelleher
added a commit
to jeromekelleher/tskit
that referenced
this issue
Jun 28, 2021
jeromekelleher
added a commit
to jeromekelleher/tskit
that referenced
this issue
Jun 28, 2021
jeromekelleher
added a commit
to jeromekelleher/tskit
that referenced
this issue
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The discussion in #343 makes it clear that it is likely that we will need to support very large tables at some point in the future, and so it would be wise to plan ahead for this. My suggestion for this is the following:
This way we'll be able to keep the library in 64bit readiness and should be able to make the jump fairly easily if/when we need to. Running the tests in 64bit mode in CI should prevent us from going down any 32 bit only rabbit holes.
Any objections?
The text was updated successfully, but these errors were encountered: