Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty word with high count when using pretrained vectors #5

Closed
gartentrio opened this issue Jun 24, 2019 · 2 comments
Closed

Empty word with high count when using pretrained vectors #5

gartentrio opened this issue Jun 24, 2019 · 2 comments

Comments

@gartentrio
Copy link

Moving a word in getInputMatrixFromFile() and then adding it to the dictionary leads to an empty word with count of vocabulary size.

std::string word;
in >> word;
words.push_back(std::move(word));
dict_->add(word);
@tshev
Copy link
Owner

tshev commented Jun 24, 2019

Thank you. Good catch.

tshev added a commit that referenced this issue Jun 24, 2019
tshev added a commit that referenced this issue Jun 24, 2019
@tshev
Copy link
Owner

tshev commented Jun 24, 2019

Fixed: #6

@tshev tshev closed this as completed Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant