Add @docusaurus/theme-classic to compilerOptions.types #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Yeah, I agree - this makes sense |
|
Should deploy voernight |
|
thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, 99,9% of users are going to use the Docusaurus classic theme anyway so it does not make sense to not include the classic theme types by default in the TS config, even if it creates some additional coupling, + it's possible to override it anyway.
When we'll have multiple themes in the future we'll create a shared package for common theme types (the Tailwind theme would have the same types as the classic theme). Still, we'll keep this coupling and bias toward the "official themes" by default for simplicity.
Related to facebook/docusaurus#5282