fix: support old nodejs without Promise.prototype.finally

tschaub · Mar 19, 2021 · fb70713 · fb70713
1 parent 3327f80
commit fb70713
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/lib/bypass.js b/lib/bypass.js
@@ -19,8 +19,17 @@ exports = module.exports = function bypass(fn) {
   try {
     result = fn();
   } finally {
-    if (result && typeof result.finally === 'function') {
-      result.finally(enable);
+    if (result && typeof result.then === 'function') {
+      result.then(
+        r => {
+          enable();
+          return r;
+        },
+        err => {
+          enable();
+          throw err;
+        }
+      );
     } else {
       enable();
     }

diff --git a/test/lib/bypass.spec.js b/test/lib/bypass.spec.js
@@ -92,7 +92,7 @@ describe('mock.bypass()', () => {
 
     promise
       .then(() => {
-        done(new Error('expected rejection'));
+        done(new Error('should not succeed'));
       })
       .catch(err => {
         assert.equal(err, error);