Disable ssl certificate verification #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated NuSpec to include Win-Arm64 and Mac-Arm64.
The Azure DevOps Pipeline Agents can't actually compile ARM64 versions of the dll and so files for Windows and Linux. They were commented out until they are able to. The macOS dylib can be built as a Universal library to support both x64 and ARM64 architectures, so the build step was modified to compile this library and copy it into the respective folders for the architectures.
|
Let me know thoughts, and if this should go to master or debug. Wasn't sure what the contribution policy was. |
This was referenced Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a flag on the init parameters to disable ssl certificate verification checks. This flag does work on windows, linux, and osx.
I didn't test if this builds and runs on anything other than osx, since that is where my main issue lies.
For OSX, the solution is to create and attach a WKNavigationDelegate and override the didReceiveAuthenticationChallenge handler.
We add the certificate/serverTrust to the list of exceptions so that the website is displayed.
While this setting is NOT recommended to be set to 'true' in a production environment, there are genuine use cases to set this flag to 'true' such as for development environments and other environments where valid ssl certificates cannot be issued due to industry standards (i.e. localhost, reserved IP addresses, private IP addresses, etc...).
DisableSslCertificateVerification -
true => SSL Certificates will not be checked for validity. Meaning any invalid certificate will be accepted
This flag can only be set on startup/show in windows and cannot be changed afterwards.
This also solves tryphotino/photino.NET#65 once appropriate changes are made to the .NET bindings.