-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: add milvus vectordb #420
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe recent changes to the LangChain solution introduce support for the Milvus database, enhancing integration testing and functionality across the framework. New project files, classes, and methods have been added to facilitate vector management and database operations. Changes also include updates to the solution configuration and test cases to streamline integration, allowing for efficient handling of vector data within the LangChain ecosystem. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Application
participant MilvusVectorDatabase
participant MilvusVectorCollection
User->>Application: Initialize Database
Application->>MilvusVectorDatabase: Create or Get Collection
MilvusVectorDatabase-->>Application: Collection Info
Application->>MilvusVectorCollection: Add Vectors
MilvusVectorCollection-->>MilvusVectorDatabase: Upsert Vectors
MilvusVectorDatabase-->>MilvusVectorCollection: Confirmation
User->>Application: Query Vectors
Application->>MilvusVectorCollection: Search Vectors
MilvusVectorCollection-->>MilvusVectorDatabase: Search Request
MilvusVectorDatabase-->>MilvusVectorCollection: Search Results
MilvusVectorCollection-->>Application: Return Results
Application-->>User: Display Results
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
…s_vectordb # Conflicts: # LangChain.sln # src/Databases/IntegrationTests/DatabaseTests.Configure.cs # src/Databases/IntegrationTests/SupportedDatabase.cs # src/Directory.Packages.props
I think all semantic-kernel connectors are similar and can be abstracted (with problems mapping metadata). First I tried to make the one from DuckDb, which seems a little simpler and for Milvus I have practically reused that one. I have not been able to configure the test containers, but I think the implementation could work, could someone help me?
tryAGI/LangChain.Databases#5
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Documentation