Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: add milvus vectordb #420

Merged
merged 3 commits into from
Aug 3, 2024

Conversation

danijerez
Copy link
Contributor

@danijerez danijerez commented Aug 3, 2024

I think all semantic-kernel connectors are similar and can be abstracted (with problems mapping metadata). First I tried to make the one from DuckDb, which seems a little simpler and for Milvus I have practically reused that one. I have not been able to configure the test containers, but I think the implementation could work, could someone help me?

tryAGI/LangChain.Databases#5

Summary by CodeRabbit

  • New Features

    • Introduced support for the Milvus database, enhancing the solution's capabilities for managing vector data.
    • Added new project and integration tests for the Milvus database, improving the testing framework's breadth.
  • Bug Fixes

    • Commented out problematic test cases related to Elasticsearch and Milvus to focus on stable database integrations.
  • Refactor

    • Improved XML formatting in package version declarations for better readability.
  • Documentation

    • Updated project references to include the new Milvus database dependencies.

@danijerez danijerez added enhancement New feature or request vector databases labels Aug 3, 2024
@danijerez danijerez requested a review from HavenDV August 3, 2024 17:51
Copy link
Contributor

coderabbitai bot commented Aug 3, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The recent changes to the LangChain solution introduce support for the Milvus database, enhancing integration testing and functionality across the framework. New project files, classes, and methods have been added to facilitate vector management and database operations. Changes also include updates to the solution configuration and test cases to streamline integration, allowing for efficient handling of vector data within the LangChain ecosystem.

Changes

File Change Summary
LangChain.sln Added projects for "Milvus" and "LangChain.Databases.Milvus," updating solution configurations and build settings.
src/Databases/IntegrationTests/DatabaseTests.Configure.cs Enhanced integration tests with Milvus setup; added container logic for etcd, MinIO, and Milvus.
src/Databases/IntegrationTests/DatabaseTests.cs Commented out test cases for Elasticsearch and Milvus, focusing on remaining supported databases.
src/Databases/IntegrationTests/LangChain.Databases.IntegrationTests.csproj Added project reference for LangChain.Databases.Milvus.
src/Databases/IntegrationTests/SupportedDatabase.cs Introduced Milvus to SupportedDatabase enumeration.
src/Databases/Milvus/src/LangChain.Databases.Milvus.csproj Created new project file targeting netstandard2.0 with essential dependencies for Milvus integration.
src/Databases/Milvus/src/MilvusVectorCollection.cs Added MilvusVectorCollection class for managing vectors, including methods for adding, deleting, and searching.
src/Databases/Milvus/src/MilvusVectorDatabase.cs Introduced MilvusVectorDatabase class implementing IVectorDatabase with methods for collection management.
src/Directory.Packages.props Cleaned up XML formatting for package version declarations for better readability.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Application
    participant MilvusVectorDatabase
    participant MilvusVectorCollection

    User->>Application: Initialize Database
    Application->>MilvusVectorDatabase: Create or Get Collection
    MilvusVectorDatabase-->>Application: Collection Info
    Application->>MilvusVectorCollection: Add Vectors
    MilvusVectorCollection-->>MilvusVectorDatabase: Upsert Vectors
    MilvusVectorDatabase-->>MilvusVectorCollection: Confirmation
    User->>Application: Query Vectors
    Application->>MilvusVectorCollection: Search Vectors
    MilvusVectorCollection-->>MilvusVectorDatabase: Search Request
    MilvusVectorDatabase-->>MilvusVectorCollection: Search Results
    MilvusVectorCollection-->>Application: Return Results
    Application-->>User: Display Results
Loading

🐰 In the meadow where data flows,
New friends in Milvus, each one glows.
Vectors dancing, tests in line,
With every change, our code will shine.
Hop along, with joy we sing,
In LangChain's heart, let Milvus spring! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

HavenDV added 2 commits August 4, 2024 00:38
…s_vectordb

# Conflicts:
#	LangChain.sln
#	src/Databases/IntegrationTests/DatabaseTests.Configure.cs
#	src/Databases/IntegrationTests/SupportedDatabase.cs
#	src/Directory.Packages.props
@HavenDV HavenDV marked this pull request as ready for review August 3, 2024 20:49
@HavenDV HavenDV merged commit 385ec29 into tryAGI:main Aug 3, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vector databases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants