-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: gemini function calling #20
Conversation
WalkthroughThe recent updates involve modifications to the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant GoogleGeminiExtensions
participant OpenApiSchema
participant ChatCompletionFunctionParameters
Client->>GoogleGeminiExtensions: Call ToGenerativeAiTools()
GoogleGeminiExtensions->>OpenApiSchema: Iterate through schemas
OpenApiSchema->>GoogleGeminiExtensions: Call ToFunctionParameters()
GoogleGeminiExtensions->>ChatCompletionFunctionParameters: Construct parameters
ChatCompletionFunctionParameters-->>GoogleGeminiExtensions: Return constructed parameters
GoogleGeminiExtensions-->>Client: Return GenerativeAITools List
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Gunpal Jain seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- src/Google/src/Extensions/GoogleGeminiExtensions.cs (1 hunks)
- src/IntegrationTests/BaseTests.cs (1 hunks)
Additional comments not posted (3)
src/Google/src/Extensions/GoogleGeminiExtensions.cs (2)
24-25
: LGTM!The changes in the
ToGenerativeAiTools
method correctly utilize theToFunctionParameters
method for constructing parameters.
30-41
: LGTM!The
ToFunctionParameters
method is well-structured and effectively encapsulates parameter construction logic.src/IntegrationTests/BaseTests.cs (1)
93-93
: Verify Google provider configuration.The inclusion of
ProviderType.Google
in theTools_Weather
test enhances test coverage.Ensure that the Google provider is correctly configured and available for testing. Run the following script to verify the configuration:
Verification successful
Google provider configuration appears to be set up correctly.
The Google provider is configured in
Helpers.cs
using an API key from the environment variableGOOGLE_API_KEY
. Ensure this environment variable is set for tests to run successfully.
- Check the environment variable
GOOGLE_API_KEY
to confirm it's set for testing.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the Google provider is correctly configured for testing. # Test: Search for Google provider configuration. Expect: Configuration details for Google provider. rg --type cs 'ProviderType.Google'Length of output: 462
Script:
#!/bin/bash # Search for configuration or setup related to the Google provider. rg --type cs 'Google' -A 5Length of output: 58508
Summary by CodeRabbit
New Features
Bug Fixes