Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: gemini function calling #20

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Fix: gemini function calling #20

merged 1 commit into from
Aug 23, 2024

Conversation

gunpal5
Copy link
Contributor

@gunpal5 gunpal5 commented Aug 23, 2024

Summary by CodeRabbit

  • New Features

    • Enhanced parameter handling for generative AI tools with a more dynamic approach.
  • Bug Fixes

    • Included the Google provider in the integration test suite, improving testing coverage.

Copy link
Contributor

coderabbitai bot commented Aug 23, 2024

Walkthrough

The recent updates involve modifications to the ToGenerativeAiTools method, transitioning to a new parameter construction approach through the ToFunctionParameters method. Additionally, the SimpleChain method in the integration tests has been updated to include an active test case for the Google provider, enhancing the test suite's coverage.

Changes

File Change Summary
src/Google/src/Extensions/GoogleGeminiExtensions.cs Altered ToGenerativeAiTools to call ToFunctionParameters for parameter construction and added the new ToFunctionParameters method.
src/IntegrationTests/BaseTests.cs Activated the TestCase(ProviderType.Google) in the SimpleChain method, including the Google provider in the tests.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant GoogleGeminiExtensions
    participant OpenApiSchema
    participant ChatCompletionFunctionParameters

    Client->>GoogleGeminiExtensions: Call ToGenerativeAiTools()
    GoogleGeminiExtensions->>OpenApiSchema: Iterate through schemas
    OpenApiSchema->>GoogleGeminiExtensions: Call ToFunctionParameters()
    GoogleGeminiExtensions->>ChatCompletionFunctionParameters: Construct parameters
    ChatCompletionFunctionParameters-->>GoogleGeminiExtensions: Return constructed parameters
    GoogleGeminiExtensions-->>Client: Return GenerativeAITools List
Loading

Poem

🐰 In a meadow bright with delight,
New methods hop, a joyful sight!
From schemas sprout, parameters flow,
Testing Google now in full glow!
With each small change, we dance and play,
Celebrating code in a cheerful way! 🌼✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Gunpal Jain seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c44d82b and eef5b18.

Files selected for processing (2)
  • src/Google/src/Extensions/GoogleGeminiExtensions.cs (1 hunks)
  • src/IntegrationTests/BaseTests.cs (1 hunks)
Additional comments not posted (3)
src/Google/src/Extensions/GoogleGeminiExtensions.cs (2)

24-25: LGTM!

The changes in the ToGenerativeAiTools method correctly utilize the ToFunctionParameters method for constructing parameters.


30-41: LGTM!

The ToFunctionParameters method is well-structured and effectively encapsulates parameter construction logic.

src/IntegrationTests/BaseTests.cs (1)

93-93: Verify Google provider configuration.

The inclusion of ProviderType.Google in the Tools_Weather test enhances test coverage.

Ensure that the Google provider is correctly configured and available for testing. Run the following script to verify the configuration:

Verification successful

Google provider configuration appears to be set up correctly.

The Google provider is configured in Helpers.cs using an API key from the environment variable GOOGLE_API_KEY. Ensure this environment variable is set for tests to run successfully.

  • Check the environment variable GOOGLE_API_KEY to confirm it's set for testing.
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that the Google provider is correctly configured for testing.

# Test: Search for Google provider configuration. Expect: Configuration details for Google provider.
rg --type cs 'ProviderType.Google'

Length of output: 462


Script:

#!/bin/bash
# Search for configuration or setup related to the Google provider.
rg --type cs 'Google' -A 5

Length of output: 58508

@HavenDV HavenDV merged commit ffed2d7 into tryAGI:main Aug 23, 2024
2 of 3 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants