Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google GenerativeAI SDK updated to latest version #163
Google GenerativeAI SDK updated to latest version #163
Changes from 3 commits
81fc988
5dac187
3168b0c
a113b13
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 4 in src/Google/src/GoogleEmbeddingModel.cs
Check failure on line 4 in src/Google/src/GoogleEmbeddingModel.cs
Check failure on line 4 in src/Google/src/GoogleEmbeddingModel.cs
Check failure on line 4 in src/Google/src/GoogleEmbeddingModel.cs
Check failure on line 5 in src/Google/src/GoogleEmbeddingModel.cs
Check failure on line 5 in src/Google/src/GoogleEmbeddingModel.cs
Check failure on line 5 in src/Google/src/GoogleEmbeddingModel.cs
Check failure on line 18 in src/Google/src/GoogleEmbeddingModel.cs
Check failure on line 18 in src/Google/src/GoogleEmbeddingModel.cs
Check failure on line 18 in src/Google/src/GoogleEmbeddingModel.cs
Check warning on line 23 in src/Google/src/GoogleEmbeddingModel.cs
Check warning on line 23 in src/Google/src/GoogleEmbeddingModel.cs
Check warning on line 23 in src/Google/src/GoogleEmbeddingModel.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add input validation for request strings.
While the request itself is validated, there's no validation for
request.Strings
. Add checks for null or empty strings to prevent potential issues.📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Provide meaningful error message.
The error message for embedding creation failure is empty. Include details about what might have caused the failure to help with debugging.
📝 Committable suggestion