Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RHOAIENG-14321): Revert metrics service target port to https #355

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

ruivieira
Copy link
Member

Reverts the operator's metrics service target port to https.

@ruivieira ruivieira added the kind/bug Something isn't working label Nov 7, 2024
@ruivieira ruivieira self-assigned this Nov 7, 2024
@ruivieira ruivieira linked an issue Nov 7, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Nov 8, 2024

PR image build and manifest generation completed successfully!

📦 PR image: quay.io/trustyai/trustyai-service-operator-ci:4e902e55f57098b9c2fd55df675589fbdbc8bf56

📦 LMES driver image: quay.io/trustyai/ta-lmes-driver:4e902e55f57098b9c2fd55df675589fbdbc8bf56

📦 LMES job image: quay.io/trustyai/ta-lmes-job:4e902e55f57098b9c2fd55df675589fbdbc8bf56

🗂️ CI manifests

devFlags:
  manifests:
    - contextDir: config
      sourcePath: ''
      uri: https://api.github.com/repos/trustyai-explainability/trustyai-service-operator-ci/tarball/operator-4e902e55f57098b9c2fd55df675589fbdbc8bf56

Copy link

openshift-ci bot commented Nov 8, 2024

@ruivieira: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/trustyai-service-operator-e2e 4e902e5 link true /test trustyai-service-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

@nehachopra27 nehachopra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nehachopra27

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruivieira ruivieira merged commit 40080ed into trustyai-explainability:main Nov 12, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working lgtm ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TrustyAI operator metrics service connecting to wrong port
2 participants