Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PVC management #347

Merged

Conversation

ruivieira
Copy link
Member

Refers:

This PR adds support for PVC has output storage for LM-Eval jobs. It supports two modes, managed PVC and existing PVC.

Managed PVC

A PVC can be specified in the LMEvalJob as

apiVersion: trustyai.opendatahub.io/v1alpha1
kind: LMEvalJob
spec:
  outputs:
    pvcManaged:
      size: 5Gi

The PVC will be created and managed by the operator, named <LMEvalJob name>-pvc. The only supported configuration at the moment is size.

Existing PVC

An existing PVC can be passed to the LM-Eval job using a PVC name, e.g.

apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: my-pvc
spec:
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 1Gi
apiVersion: trustyai.opendatahub.io/v1alpha1
kind: LMEvalJob
spec:
  outputs:
    pvcName: my-pvc

This PVC will not be managed by the operator.
If both managed and existing PVC are specified, the operator will prefer the managed configuration and ignore the existing PVC one.

@ruivieira ruivieira added kind/enhancement New feature or request lm-eval Issues related to LM-Eval labels Oct 27, 2024
@ruivieira ruivieira self-assigned this Oct 27, 2024
@ruivieira ruivieira requested a review from yhwang October 27, 2024 18:28
@ruivieira ruivieira linked an issue Oct 27, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Oct 27, 2024

PR image build and manifest generation completed successfully!

📦 PR image: quay.io/trustyai/trustyai-service-operator-ci:f72ca2dfbe5bfe22a2cdc6eab71712a5654c1c29

📦 LMES driver image: quay.io/trustyai/ta-lmes-driver:f72ca2dfbe5bfe22a2cdc6eab71712a5654c1c29

📦 LMES job image: quay.io/trustyai/ta-lmes-job:f72ca2dfbe5bfe22a2cdc6eab71712a5654c1c29

🗂️ CI manifests

devFlags:
  manifests:
    - contextDir: config
      sourcePath: ''
      uri: https://api.github.com/repos/trustyai-explainability/trustyai-service-operator-ci/tarball/operator-f72ca2dfbe5bfe22a2cdc6eab71712a5654c1c29

Copy link

openshift-ci bot commented Oct 27, 2024

@ruivieira: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/trustyai-service-operator-e2e f72ca2d link true /test trustyai-service-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Collaborator

@yhwang yhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Great feature!

Copy link

openshift-ci bot commented Oct 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: christinaexyou, yhwang

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruivieira ruivieira merged commit b76a51d into trustyai-explainability:main Oct 29, 2024
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request lgtm lm-eval Issues related to LM-Eval ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PVC as storage option for LM-Eval results
3 participants