-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PVC management #347
Add PVC management #347
Conversation
PR image build and manifest generation completed successfully! 📦 PR image: 📦 LMES driver image: 📦 LMES job image: 🗂️ CI manifests
|
@ruivieira: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
Great feature!
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: christinaexyou, yhwang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b76a51d
into
trustyai-explainability:main
Refers:
This PR adds support for PVC has output storage for LM-Eval jobs. It supports two modes, managed PVC and existing PVC.
Managed PVC
A PVC can be specified in the
LMEvalJob
asThe PVC will be created and managed by the operator, named
<LMEvalJob name>-pvc
. The only supported configuration at the moment issize
.Existing PVC
An existing PVC can be passed to the LM-Eval job using a PVC name, e.g.
This PVC will not be managed by the operator.
If both managed and existing PVC are specified, the operator will prefer the managed configuration and ignore the existing PVC one.