-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OAuth to external endpoints #140
Merged
ruivieira
merged 30 commits into
trustyai-explainability:main
from
ruivieira:issue-135-oauth-proxy
Nov 28, 2023
Merged
Add OAuth to external endpoints #140
ruivieira
merged 30 commits into
trustyai-explainability:main
from
ruivieira:issue-135-oauth-proxy
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruivieira
requested review from
tteofili and
RobGeada
and removed request for
a team
November 6, 2023 10:45
ruivieira
changed the title
[WIP] Add OAuth to external endpoints
Add OAuth to external endpoints
Nov 8, 2023
ruivieira
modified the milestones:
Release 1.12.0 (Operator),
Release 1.13.0 (Operator)
Nov 13, 2023
# Conflicts: # config/rbac/kustomization.yaml # controllers/suite_test.go
reconciliation
tteofili
approved these changes
Nov 20, 2023
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tteofili The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
/test all |
# Conflicts: # config/base/kustomization.yaml # config/rbac/role.yaml
/test all |
ruivieira
pushed a commit
to ruivieira/trustyai-service-operator
that referenced
this pull request
Jan 5, 2025
…ices/konflux/component-updates/ta-lmes-driver-216 chore(deps): update ta-lmes-driver-216 to 18a9e67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add authentication to external endpoints (
Route
) for the TrustyAI service.Each TrustyAI service will now require authentication for both browser and direct HTTP access.
When using from the browser, a login page will be presented (if the user is not already logged in).
When using direct HTTP access, a user token can be used for authentication.
Implementation
The operator now deploys an oauth-proxy sidecar container to each TrustyAI service.
The operator also provides a service account for each oauth-proxy with permissions for
tokenreviews
andsubjectaccessreviews
.The route will now direct traffic to oauth-proxy which authenticate provided user credentials (user tokens for HTTP access).
Example (HTTP)
Assuming a TrustyAI service named
trustyai-service
in namespacetest
: