Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(XRP): Add support for signing a raw JSON transaction #4258

Merged
merged 5 commits into from
Feb 11, 2025

Conversation

satoshiotomakan
Copy link
Collaborator

Description

Add support for signing a raw JSON transaction, in particular, swap.

Types of changes

  • Add SigningInput.rawJson string. If set, SigningInput.operationOneof is ignored
  • Add XRPLTypes::STArray and XRPLTypes::STObject

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

Copy link

github-actions bot commented Feb 10, 2025

Binary size comparison

➡️ aarch64-apple-ios:

- 13.50 MB
+ 13.54 MB 	 +37 KB

➡️ aarch64-apple-ios-sim:

- 13.50 MB
+ 13.54 MB 	 +37 KB

➡️ aarch64-linux-android:

- 17.72 MB
+ 17.77 MB 	 +56 KB

➡️ armv7-linux-androideabi:

- 14.89 MB
+ 14.93 MB 	 +42 KB

➡️ wasm32-unknown-emscripten:

- 12.58 MB
+ 12.62 MB 	 +46 KB

rust/chains/tw_ripple/src/compiler.rs Outdated Show resolved Hide resolved
rust/chains/tw_ripple/src/signer.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@gupnik gupnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@satoshiotomakan satoshiotomakan merged commit 98e56c6 into master Feb 11, 2025
14 checks passed
@satoshiotomakan satoshiotomakan deleted the s/xrp-json-signing branch February 11, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants