[Sui]: Adds support for remaining commands/call_args/input_args in raw json #4252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary size comparison➡️ aarch64-apple-ios: - 13.04 MB
+ 13.10 MB +56 KB➡️ aarch64-apple-ios-sim: - 13.04 MB
+ 13.10 MB +56 KB➡️ aarch64-linux-android: - 16.97 MB
+ 17.05 MB +83 KB➡️ armv7-linux-androideabi: - 14.31 MB
+ 14.37 MB +61 KB➡️ wasm32-unknown-emscripten: - 12.04 MB
+ 12.12 MB +73 KB |
satoshiotomakan
requested changes
Feb 4, 2025
There was a problem hiding this comment.
Please use https://j-brooke.github.io/FracturedJson/ with Max Inline Complexity = 1 and Max Total Line Length = 150 to avoid having 6k file changes.
satoshiotomakan
previously approved these changes
Feb 5, 2025
satoshiotomakan
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds nested result in
TransactionArgwhile parsing raw json for Sui.How to test
Updated the test for a sample json.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
If you're adding a new blockchain