Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for integers in automatic FFI generation #4251

Merged
merged 7 commits into from
Feb 10, 2025

Conversation

gupnik
Copy link
Collaborator

@gupnik gupnik commented Feb 4, 2025

Description

This PR adds ability to automatically generate FFI C++ code for Rust functions with integer params and return types.

How to test

Added a Test file as well

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

Copy link

github-actions bot commented Feb 4, 2025

Binary size comparison

➡️ aarch64-apple-ios: 13.50 MB

➡️ aarch64-apple-ios-sim: 13.50 MB

➡️ aarch64-linux-android:

- 17.72 MB
+ 17.72 MB 	 -1 KB

➡️ armv7-linux-androideabi: 14.89 MB

➡️ wasm32-unknown-emscripten: 12.58 MB

Copy link
Collaborator

@satoshiotomakan satoshiotomakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@satoshiotomakan satoshiotomakan merged commit 2b0762d into master Feb 10, 2025
14 checks passed
@satoshiotomakan satoshiotomakan deleted the gupnik/rust-ffi-integers branch February 10, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants