Adds ability to serialise Raw Sui Swap transactions #4247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satoshiotomakan
requested changes
Jan 31, 2025
Binary size comparison➡️ aarch64-apple-ios: - 12.92 MB
+ 13.04 MB +125 KB➡️ aarch64-apple-ios-sim: - 12.92 MB
+ 13.04 MB +125 KB➡️ aarch64-linux-android: - 16.78 MB
+ 16.97 MB +196 KB➡️ armv7-linux-androideabi: - 14.16 MB
+ 14.31 MB +150 KB➡️ wasm32-unknown-emscripten: - 11.89 MB
+ 12.04 MB +157 KB |
satoshiotomakan
requested changes
Feb 3, 2025
Comment on lines
+272
to
+275
| let Some(gas_payment) = gas_payments.first() else { | ||
| return SigningError::err(SigningErrorType::Error_invalid_params) | ||
| .context("Gas payment is missing from the transaction"); | ||
| }; |
There was a problem hiding this comment.
We should not ignore other gas payments. As I can see, TransactionData::new() takes only one gas payment, but GasData allows to store multiple payments.
Please change the signature of the TransactionData::new() function to be able to take a list of gas payments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to accept a raw json and serialise into a Sui Transaction.
How to test
Run tests across all platforms
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
If you're adding a new blockchain