Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Kotlin] Nullable constructors throw exception #3095

Merged
merged 2 commits into from
Apr 20, 2023
Merged

[Kotlin] Nullable constructors throw exception #3095

merged 2 commits into from
Apr 20, 2023

Conversation

MaximPestryakov
Copy link
Contributor

Description

  • Kotlin doesn't have nullable constructors like Swift, so simply throw IllegalArgumentException if native constructor returns null
  • Added stringValuse for enums with string value
  • Use interface instead of class/object for safety in JS accessors
  • Public getter for WalletCore.Instance in JS target
  • Switch to Java 17 (new Android Studio requires it)

hewigovens
hewigovens reviewed Apr 20, 2023
View reviewed changes
Copy link
Contributor

@hewigovens hewigovens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to have a test

@Milerius
Copy link
Collaborator

would be nice to have a test

^

@Milerius Milerius merged commit f302232 into master Apr 20, 2023
@Milerius Milerius deleted the kotlin_nullable_constructors branch April 20, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hewigovens hewigovens hewigovens left review comments

@AndrewChupin AndrewChupin AndrewChupin approved these changes

@Milerius Milerius Milerius approved these changes

@rsrbk rsrbk Awaiting requested review from rsrbk

@satoshiotomakan satoshiotomakan Awaiting requested review from satoshiotomakan satoshiotomakan is a code owner

@lamafab lamafab Awaiting requested review from lamafab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaximPestryakov @Milerius @hewigovens @AndrewChupin