Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ZkSync]: Add support for ZkSync V2 mainnet #2768

Merged
merged 5 commits into from
Feb 17, 2023
Merged

[ZkSync]: Add support for ZkSync V2 mainnet #2768

merged 5 commits into from
Feb 17, 2023

Conversation

miloserdow
Copy link
Contributor

@miloserdow miloserdow commented Nov 30, 2022 •
edited
Loading

Description

We currently support zkSync v2 testnet, this PR changes zkSync to mainnet.

How to test

Unit tests

Types of changes

Checklist

  • Update existing tests and registry

hewigovens
hewigovens previously approved these changes Nov 30, 2022
View reviewed changes
@hewigovens
Copy link
Contributor

I think you only need to add one L2 transfer test or L2 -> test

Milerius
Milerius reviewed Nov 30, 2022
View reviewed changes
Copy link
Collaborator

@Milerius Milerius left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, few things:

  • Unit tests is failing on linux
  • There is no link to the mainnet transaction in the unit test.

@miloserdow miloserdow marked this pull request as ready for review December 2, 2022 17:22
@miloserdow miloserdow requested a review from optout21 as a code owner December 2, 2022 17:22
hewigovens
hewigovens previously approved these changes Dec 3, 2022
View reviewed changes
optout21
optout21 suggested changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@optout21 optout21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • In the registry.json there is no sample (real) tx and address fields, please add some
  • Why did you remove the signer tests, not update them?

@miloserdow
Copy link
Contributor Author

Sorry, this should've been a draft PR - I'm still waiting for alpha/beta mainnet launch as now it's restricted to zkSync devs only.

@miloserdow miloserdow marked this pull request as draft December 9, 2022 13:11
@Milerius Milerius marked this pull request as ready for review February 17, 2023 08:58
@Milerius Milerius requested a review from rsrbk as a code owner February 17, 2023 08:58
Milerius
Milerius approved these changes Feb 17, 2023
View reviewed changes
Copy link
Collaborator

@Milerius Milerius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EVM unit tests will be added to wallet kit, 100% compatible as other EVM chains, should be smooth.

@Milerius Milerius merged commit a118655 into master Feb 17, 2023
@Milerius Milerius deleted the v/zksync-mainnet branch February 17, 2023 10:14
DeanDonkov pushed a commit to changex-app/wallet-core that referenced this pull request Apr 7, 2023
@miloserdow @DeanDonkov
[ZkSync]: Add support for ZkSync Era mainnet (trustwallet#2768)
bc21ad5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@optout21 optout21 optout21 requested changes

@hewigovens hewigovens hewigovens approved these changes

@Milerius Milerius Milerius approved these changes

@rsrbk rsrbk Awaiting requested review from rsrbk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miloserdow @hewigovens @optout21 @Milerius