Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change encoding for BitstringStatusList encodedList to multibase #1800

Merged

Conversation

bstasyszyn
Copy link
Contributor

@bstasyszyn bstasyszyn commented Nov 22, 2024

BitstringStatusList encodedList is encoded as multibase base64url (with no padding).

@bstasyszyn bstasyszyn changed the title fix: Change encoding for BitstringStatusList encodedList to multibase… fix: Change encoding for BitstringStatusList encodedList to multibaseurl Nov 22, 2024
@bstasyszyn bstasyszyn changed the title fix: Change encoding for BitstringStatusList encodedList to multibaseurl fix: Change encoding for BitstringStatusList encodedList to multibase Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 90.13158% with 15 lines in your changes missing coverage. Please review.

Project coverage is 84.87%. Comparing base (c0362a2) to head (5b70ee2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/doc/vc/statustype/statusprocessor.go 85.07% 7 Missing and 3 partials ⚠️
...dentialstatus/eventhandler/eventhandler_service.go 57.14% 2 Missing and 1 partial ⚠️
pkg/internal/mock/status/status.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1800      +/-   ##
==========================================
+ Coverage   84.80%   84.87%   +0.06%     
==========================================
  Files         193      193              
  Lines       17635    17751     +116     
==========================================
+ Hits        14956    15066     +110     
- Misses       2141     2146       +5     
- Partials      538      539       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

… base64url

Signed-off-by: Bob Stasyszyn <bob.stasyszyn@gendigital.com>
@bstasyszyn bstasyszyn force-pushed the bitstring-statuslist-encoding-2 branch from db67c65 to 5b70ee2 Compare November 22, 2024 17:42
@bstasyszyn bstasyszyn merged commit 94e2ea6 into trustbloc:main Nov 22, 2024
8 of 9 checks passed
@bstasyszyn bstasyszyn deleted the bitstring-statuslist-encoding-2 branch November 22, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants