Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: notification endpoint update #1796

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

mishasizov-SK
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 97.10145% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.83%. Comparing base (26a711c) to head (e51b69d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/storage/redis/ackstore/ackstore.go 76.92% 2 Missing and 1 partial ⚠️
pkg/service/oidc4ci/oidc4ci_service.go 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1796      +/-   ##
==========================================
- Coverage   84.83%   84.83%   -0.01%     
==========================================
  Files         193      193              
  Lines       17584    17626      +42     
==========================================
+ Hits        14918    14953      +35     
- Misses       2132     2137       +5     
- Partials      534      536       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Signed-off-by: Misha Sizov <mykhailo.sizov@securekey.com>
@mishasizov-SK mishasizov-SK force-pushed the feat-notification-endpoint branch from 99ee2b4 to e51b69d Compare November 20, 2024 13:22
@fqutishat fqutishat merged commit a808e30 into trustbloc:main Nov 20, 2024
9 of 10 checks passed
@mishasizov-SK mishasizov-SK deleted the feat-notification-endpoint branch November 20, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants