chore: Bump version of aws-sdk-go and otel libraries #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1734 +/- ##
==========================================
- Coverage 85.92% 85.82% -0.10%
==========================================
Files 172 182 +10
Lines 12099 12560 +461
==========================================
+ Hits 10396 10780 +384
- Misses 1245 1313 +68
- Partials 458 467 +9 ☔ View full report in Codecov by Sentry. |
0c7ad6f to
615bfec
Compare
Also fixed the prometheus echo handler so that it doesn' invoke the error handle on the context, since this results in the error being handled twice. A consequence of this is that you may get "superfluous http writes" errors. Signed-off-by: Bob Stasyszyn <bob.stasyszyn@gendigital.com>
615bfec to
e4f97de
Compare
fqutishat
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed the prometheus echo handler so that it doesn't invoke the error handler on the echo context, since this results in the error being handled twice. A consequence of this is that you may get "superfluous http writes" errors.