Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: basic compose #1665

Conversation

skynet2
Copy link
Member

@skynet2 skynet2 commented Mar 18, 2024

No description provided.

@cla-bot cla-bot bot added the cla-signed label Mar 18, 2024
@skynet2 skynet2 marked this pull request as draft March 18, 2024 12:50
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 89.23077% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 86.01%. Comparing base (f6dac7d) to head (18e3cb3).
Report is 2 commits behind head on multiple_credentials_issuance.

Files Patch % Lines
...rvice/oidc4ci/oidc4ci_service_initiate_issuance.go 87.17% 4 Missing and 1 partial ⚠️
pkg/service/oidc4ci/oidc4ci_service.go 88.88% 2 Missing and 2 partials ⚠️
...service/issuecredential/issuecredential_service.go 57.14% 3 Missing ⚠️
pkg/service/oidc4ci/composer.go 92.59% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##           multiple_credentials_issuance    #1665      +/-   ##
=================================================================
+ Coverage                          85.96%   86.01%   +0.05%     
=================================================================
  Files                                171      172       +1     
  Lines                              11746    11841      +95     
=================================================================
+ Hits                               10097    10185      +88     
- Misses                              1198     1203       +5     
- Partials                             451      453       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skynet2 skynet2 marked this pull request as ready for review March 19, 2024 11:20
@mishasizov-SK mishasizov-SK merged commit b96e240 into trustbloc:multiple_credentials_issuance Mar 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants