Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Additional fields in verifier oidc events payload #1620

Merged
merged 1 commit into from
Mar 12, 2024
Merged

feat: Additional fields in verifier oidc events payload #1620

merged 1 commit into from
Mar 12, 2024

Conversation

bstasyszyn
Copy link
Contributor

@bstasyszyn bstasyszyn commented Mar 6, 2024 •
edited
Loading

Added an array of credential fields to the verifier.oidc-interaction-succeeded and verifier.oidc-interaction-claims-retrieved event payloads:

  • Credential ID
  • Credential types
  • Credential subject ID
  • Issuer ID

@cla-bot cla-bot bot added the cla-signed label Mar 6, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.74359% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 85.49%. Comparing base (b775057) to head (8eb3f9a).

Files Patch % Lines
pkg/service/oidc4vp/oidc4vp_service.go 89.74% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1620      +/-   ##
==========================================
+ Coverage   85.44%   85.49%   +0.05%     
==========================================
  Files         172      172              
  Lines       11369    11395      +26     
==========================================
+ Hits         9714     9742      +28     
+ Misses       1202     1201       -1     
+ Partials      453      452       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bstasyszyn bstasyszyn marked this pull request as draft March 6, 2024 21:11
@bstasyszyn bstasyszyn changed the title Add fields to verifier.oidc-interaction-succeeded payload feat: Add fields to verifier.oidc-interaction-succeeded payload Mar 7, 2024
@bstasyszyn bstasyszyn force-pushed the verification-event branch from f655254 to b655a02 Compare March 7, 2024 14:11
@bstasyszyn bstasyszyn changed the title feat: Add fields to verifier.oidc-interaction-succeeded payload feat: Additional fields in verifier oidc events payload Mar 7, 2024
@bstasyszyn bstasyszyn force-pushed the verification-event branch from b655a02 to cfb89a9 Compare March 7, 2024 15:09
@bstasyszyn bstasyszyn marked this pull request as ready for review March 7, 2024 15:09
@bstasyszyn
Additional fields in verifier oidc events payload
8eb3f9a 
Added an array of credential fields to the verifier.oidc-interaction-succeeded and verifier.oidc-interaction-claims-retrieved event payloads:

- Credential ID
- Credential types
- Credential subject ID
- Issuer ID

Signed-off-by: Bob Stasyszyn <bob.stasyszyn@gendigital.com>
@bstasyszyn bstasyszyn force-pushed the verification-event branch from cfb89a9 to 8eb3f9a Compare March 7, 2024 17:06
@fqutishat fqutishat merged commit 5cca6d7 into trustbloc:main Mar 12, 2024
10 checks passed
@bstasyszyn bstasyszyn deleted the verification-event branch March 12, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fqutishat fqutishat fqutishat approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bstasyszyn @fqutishat